Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI 設定変更 #1285

Merged
merged 2 commits into from
Apr 5, 2023
Merged

CI 設定変更 #1285

merged 2 commits into from
Apr 5, 2023

Conversation

jay-es
Copy link
Member

@jay-es jay-es commented Mar 31, 2023

textlint の GitHub Action が下記のエラーになっているので、Node 18 を使うように設定を変更しました

Run npx pnpm i
npx: installed 1 in 1.591s
ERROR: This version of pnpm requires at least Node.js v16.14
The current version of Node.js is v14.21.3

@vercel
Copy link

vercel bot commented Mar 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
docs-ja ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 31, 2023 at 10:43AM (UTC)

Comment on lines +3 to +7
on:
push:
branches:
- main
pull_request:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ryu-cho での PR 作成時に 2 回ずつ実行されていたので設定変更しました

Comment on lines +15 to +16
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
Copy link
Member Author

@jay-es jay-es Mar 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ついでに v3 に更新

with:
node-version: '14'
node-version: 18
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここがメインの修正です

@jay-es jay-es marked this pull request as ready for review March 31, 2023 10:49
@jay-es jay-es requested a review from kazupon March 31, 2023 10:49
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

@kazupon kazupon merged commit ad1136c into vuejs-translations:main Apr 5, 2023
@jay-es jay-es deleted the ci branch April 5, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants