Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: composition-api-setup.md translation #18

Merged
merged 3 commits into from
Aug 13, 2023
Merged

docs: composition-api-setup.md translation #18

merged 3 commits into from
Aug 13, 2023

Conversation

abuansarpatowary
Copy link
Contributor

Description of Problem

Proposed Solution

Additional Information

@abuansarpatowary
Copy link
Contributor Author

@mahmudunnabikajal all done from the new branch. Check this out now

@mahmudunnabikajal
Copy link
Member

mahmudunnabikajal commented Aug 11, 2023 •
edited
Loading

@abuansarpatowary checking.

Update: Checking done. Some corrections with comment add in code.

@mahmudunnabikajal mahmudunnabikajal linked an issue Aug 11, 2023 that may be closed by this pull request
api/composition-api-setup.md #17
Closed
@mahmudunnabikajal mahmudunnabikajal added the documentation Improvements or additions to documentation label Aug 11, 2023
@mahmudunnabikajal mahmudunnabikajal changed the title composition-api-setup page translated docs: composition-api-setup.md translation Aug 11, 2023
@abuansarpatowary
Copy link
Contributor Author

@mahmudunnabikajal everything is okay on your side to accept my translation?

mahmudunnabikajal
mahmudunnabikajal requested changes Aug 11, 2023
View reviewed changes
Copy link
Member

@mahmudunnabikajal mahmudunnabikajal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abuansarpatowary Check this correction

src/api/composition-api-setup.md Outdated Show resolved Hide resolved
src/api/composition-api-setup.md Outdated Show resolved Hide resolved
src/api/composition-api-setup.md Outdated Show resolved Hide resolved
@abuansarpatowary
Copy link
Contributor Author

@mahmudunnabikajal changed the issues that you mentioned

mahmudunnabikajal
mahmudunnabikajal requested changes Aug 11, 2023
View reviewed changes
Copy link
Member

@mahmudunnabikajal mahmudunnabikajal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abuansarpatowary check similar errors.

@abuansarpatowary
Copy link
Contributor Author

@mahmudunnabikajal check this now. Fixes all error that you mentioned

@mahmudunnabikajal mahmudunnabikajal merged commit 7a7e1a5 into vuejs-translations:api/composition-api-setup.md Aug 13, 2023
1 check passed
@mahmudunnabikajal mahmudunnabikajal mentioned this pull request Aug 13, 2023
Closed
@mahmudunnabikajal
Copy link
Member

@abuansarpatowary translation already merge with branch api/composition-api-setup.md and i see you don't translate from line 82 to 171 . Make sure you are translating updated code from main branch. Check and create a pull request on branch api/composition-api-setup.md again.

@abuansarpatowary
Copy link
Contributor Author

@mahmudunnabikajal entire page has been translated now.

@mahmudunnabikajal mahmudunnabikajal linked an issue Sep 10, 2023 that may be closed by this pull request
Follow-up of the translation process #1
Closed
@mahmudunnabikajal mahmudunnabikajal removed a link to an issue Sep 10, 2023
Follow-up of the translation process #1
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahmudunnabikajal mahmudunnabikajal mahmudunnabikajal requested changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

api/composition-api-setup.md
2 participants
@abuansarpatowary @mahmudunnabikajal