Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly set value for the ListElement on load #92

Conversation

mpopelo
Copy link

@mpopelo mpopelo commented Dec 4, 2023

πŸ”— Linked issue

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Currently, in the ListElement component, when data is loaded using the load() method, the value property is incorrectly set to [undefined, undefined, ...]. This pull request addresses this issue by ensuring that the ListElement correctly initializes the value property with the appropriate values.

πŸ“ Checklist

  • I have linked an issue or discussion.

@adamberecz
Copy link
Collaborator

Thanks for the PR. Right now I can see that list items are added upon load with undefined values and a tick later the values are loaded. Could you please give me an example when this becomes an issue? It would help me to understand if the change is required, because it affect other things (tests break).

@adamberecz
Copy link
Collaborator

Closing this due to inactivity.

@adamberecz adamberecz closed this May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants