check typeof offscreen canvas in IIFE

[sashankaryal]

What changes are proposed in this pull request?

self might not be defined in some contexts

How is this patch tested? If it is not, please explain why.

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

• No. You can skip the rest of this section.
• Yes. Give a description of this change to be included in the release
  notes for FiftyOne users.

What areas of FiftyOne does this PR affect?

• App: FiftyOne application changes
• Build: Build and test infrastructure changes
• Core: Core fiftyone Python library changes
• Documentation: FiftyOne documentation changes
• Other

Summary by CodeRabbit

• Bug Fixes
  • Improved compatibility check for OffscreenCanvas to prevent potential runtime errors in different environments.

[coderabbitai]

Walkthrough

The pull request modifies the detection mechanism for OffscreenCanvas in the canvas decoder worker. The change replaces the previous string presence check with a more precise type existence check, ensuring that OffscreenCanvas is not only referenced but properly defined. This adjustment aims to improve the robustness of canvas-related operations by preventing potential errors in environments with limited or inconsistent OffscreenCanvas support.

Changes

File	Change Summary
app/packages/looker/src/worker/canvas-decoder.ts	Updated OffscreenCanvas detection from "OffscreenCanvas" in self to typeof OffscreenCanvas !== "undefined"

Suggested labels

app

Suggested reviewers

• benjaminpkane

Possibly related PRs

• performance: use offscreen canvas to decode on-disk masks #5089: Involves OffscreenCanvas usage for image decoding, directly related to the canvas detection modification

Poem

🐰 A canvas check, so crisp and neat
Where OffscreenCanvas now feels complete
No more string tricks, just pure type test
Our decoder worker passes every quest!
Code precision, rabbit's delight 🎨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 496e962 and ca5861d.

📒 Files selected for processing (1)

• app/packages/looker/src/worker/canvas-decoder.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

app/packages/looker/src/worker/canvas-decoder.ts (1)

Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.

🔇 Additional comments (1)

app/packages/looker/src/worker/canvas-decoder.ts (1)

5-5: LGTM! Improved type checking mechanism.

The change from "OffscreenCanvas" in self to typeof OffscreenCanvas !== "undefined" is a more robust way to check for feature availability. This approach directly verifies the type's existence rather than checking for a string property in the global scope.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.