Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README Refresh Pass #5352

Merged
merged 1 commit into from
Jan 7, 2025
Merged

README Refresh Pass #5352

merged 1 commit into from
Jan 7, 2025

Conversation

benjaminpkane
Copy link
Contributor

@benjaminpkane benjaminpkane commented Jan 7, 2025

What changes are proposed in this pull request?

Refreshed README pass

  • FiftyOne naming consistency
  • FFMPEG -> FFmpeg

I don't believe Git is explicitly required, so that language was removed. And other small simplifications.

Formatting from prettier. This is automatic when pre-commit is installed.

pre-commit install

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Summary by CodeRabbit

  • Documentation
    • Updated README formatting for improved readability
    • Clarified Python version support (3.9 to 3.11)
    • Refined installation instructions for Windows, Linux, and macOS
    • Consistently capitalized "FiftyOne" throughout the document

@benjaminpkane benjaminpkane added the documentation Documentation work label Jan 7, 2025
@benjaminpkane benjaminpkane self-assigned this Jan 7, 2025
Copy link
Contributor

coderabbitai bot commented Jan 7, 2025

Walkthrough

The pull request focuses on improving the README.md file for the FiftyOne project. The changes primarily involve formatting and textual refinements, including consistent capitalization of "FiftyOne," improved readability through line breaks and spacing, and clarified installation instructions. The updates target documentation clarity and presentation, ensuring consistent terminology and more user-friendly guidance for Python version support and installation processes across different operating systems.

Changes

File Change Summary
README.md - Capitalized "FiftyOne" consistently throughout the document
- Refined Python version support details (3.9 to 3.11)
- Improved installation instructions formatting
- Enhanced readability through spacing and line breaks

Suggested Reviewers

  • brimoor
  • swheaton

Possibly related PRs

Poem

🐰 A README so crisp and bright,
Words aligned with rabbit-like might
FiftyOne, capitalized with care
Documentation beyond compare!
Clarity springs from every line ✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (6)
README.md (6)

39-42: Consider rephrasing the introduction for better flow.

The current paragraph has awkward line breaks and could be more concise.

-We created an open-source tool that supercharges your computer vision and
-machine learning workflows by enabling you to visualize datasets, analyze
-models, and improve data quality more efficiently than ever before. Embark with
-us in this adventure 🤝. **[FiftyOne](https://fiftyone.ai)**.
+FiftyOne is an open-source tool that supercharges computer vision and machine learning workflows by enabling you to visualize datasets, analyze models, and improve data quality more efficiently than ever before. Join us on this adventure 🤝 with **[FiftyOne](https://fiftyone.ai)**.

59-63: Fix grammatical and clarity issues in the installation description.

The text contains redundant phrases and grammatical issues.

-provide two ways for being installed. The first one is through PyPI, and the
-second is through a local installation. PyPI is the straight forward
-installation method if you are not looking for any changes in the source code,
-if you want to make changes to the source code, then a local installation is
-recommended.
+provide two installation methods: PyPI and local installation. PyPI is the straightforward choice if you don't plan to modify the source code. If you want to contribute or make changes to the source code, then local installation is recommended.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~60-~60: The adjective or adverb “straightforward” (= easy, precise) is spelled as one word.
Context: ...rough a local installation. PyPI is the straight forward installation method if you are not look...

(STRAIGHT_FORWARD_COMPOUND)


[style] ~62-~62: Consider shortening or rephrasing this to strengthen your wording.
Context: ...nges in the source code, if you want to make changes to the source code, then a local installat...

(MAKE_CHANGES)


193-196: Improve formatting and clarity in prerequisites introduction.

The text contains formatting inconsistencies and could be more clear.

-**FiftyOne** supports Python 3.9 - 3.11. To get started, select the guide for
-your operating system or environment, if you are an experienced developer you
-can skip this section. If you are looking for scaling solution to be installed
-in Cloud Enterprise Systems, please take a look of **FiftyOne Teams**
+**FiftyOne** supports Python 3.9–3.11. To get started, select the guide for
+your operating system or environment. Experienced developers may skip this section.
+If you're looking for a scalable solution for Cloud Enterprise Systems,
+check out **FiftyOne Teams**
🧰 Tools
🪛 LanguageTool

[typographical] ~193-~193: If you want to indicate numerical ranges or time ranges, consider using an en dash.
Context: ...ers 🧸 FiftyOne supports Python 3.9 - 3.11. To get started, select the guide f...

(DASH_RULE)


208-220: Improve clarity in Windows installation instructions.

The instructions could be more structured and clear.

-**Note:** ⚠️ The version of Python that is available in the Microsoft Store is
-**not recommended**.
-
-Download a Python installer from
-[python.org](https://www.python.org/downloads/). Choose Python **3.9**,
-**3.10**, or **3.11** and make sure to pick a **64-bit** version. For example,
-this
-[Python 3.10.11 installer](https://www.python.org/ftp/python/3.10.11/python-3.10.11-amd64.exe).
-Double-click on the installer to run it, and follow the steps in the installer.
-
--   **Check the box to add Python to your PATH**, and to install py.
--   At the end of the installer, there is an option to **disable the PATH
-    length limit**. It is recommended to click this.
+⚠️ **Important:** Do not use the Python version from the Microsoft Store.
+
+1. Download a Python installer from [python.org](https://www.python.org/downloads/):
+   - Choose Python **3.9**, **3.10**, or **3.11**
+   - Select the **64-bit** version
+   - Example: [Python 3.10.11 installer](https://www.python.org/ftp/python/3.10.11/python-3.10.11-amd64.exe)
+
+2. Run the installer:
+   - **Check the box to add Python to your PATH**
+   - At the end, click the option to **disable the PATH length limit**

409-438: Fix bare URLs in media links.

The media links should be properly formatted according to Markdown best practices.

Replace the bare URLs with properly formatted Markdown links:

-https://github.com/user-attachments/assets/af8cd626-57b7-4f2a-96bf-1c8a513c2e2b
+![Visualize Complex Datasets](https://github.com/user-attachments/assets/af8cd626-57b7-4f2a-96bf-1c8a513c2e2b)

(Apply similar changes to other media links)

🧰 Tools
🪛 Markdownlint (0.37.0)

409-409: null
Bare URL used

(MD034, no-bare-urls)


414-414: null
Bare URL used

(MD034, no-bare-urls)


420-420: null
Bare URL used

(MD034, no-bare-urls)


425-425: null
Bare URL used

(MD034, no-bare-urls)


427-427: null
Bare URL used

(MD034, no-bare-urls)


433-433: null
Bare URL used

(MD034, no-bare-urls)


438-438: null
Bare URL used

(MD034, no-bare-urls)


521-522: Fix formatting in social media section.

The text contains formatting issues and could be more concise.

-**Share your workflow improvements on social media and tag us @Voxel51 and
-#FiftyOne!**.
+**Share your workflow improvements on social media and tag us @Voxel51 and #FiftyOne!**
🧰 Tools
🪛 Markdownlint (0.37.0)

522-522: null
No space after hash on atx style heading

(MD018, no-missing-space-atx)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eb4eca9 and bd73519.

📒 Files selected for processing (1)
  • README.md (13 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md

[typographical] ~57-~57: If you want to indicate numerical ranges or time ranges, consider using an en dash.
Context: ...mmary> FiftyOne supports Python 3.9 - 3.11. See the [prerequisites section](#-...

(DASH_RULE)


[uncategorized] ~58-~58: When ‘system-specific’ is used as a modifier, it is usually spelled with a hyphen.
Context: ...equisites section](#-prerequisites) for system specific information. We provide two ways for be...

(SPECIFIC_HYPHEN)


[uncategorized] ~60-~60: The adjective or adverb “straightforward” (= easy, precise) is spelled as one word.
Context: ...rough a local installation. PyPI is the straight forward installation method if you are not look...

(STRAIGHT_FORWARD_COMPOUND)


[style] ~62-~62: Consider shortening or rephrasing this to strengthen your wording.
Context: ...nges in the source code, if you want to make changes to the source code, then a local installat...

(MAKE_CHANGES)


[typographical] ~193-~193: If you want to indicate numerical ranges or time ranges, consider using an en dash.
Context: ...ers 🧸 FiftyOne supports Python 3.9 - 3.11. To get started, select the guide f...

(DASH_RULE)


[grammar] ~222-~222: The word ‘Install’ is not a noun.
Context: ...is recommended to click this. #### 1.2 Install Git Download Git from [this link](http...

(A_INSTALL)


[grammar] ~263-~263: The word ‘install’ is not a noun.
Context: ...untu Linux. These steps work on a clean install of Ubuntu Desktop 24.04, and should als...

(A_INSTALL)


[grammar] ~356-~356: The operating system from Apple is written “macOS”.
Context: ... Linux | macOS | Docker | |...

(MAC_OS)

🪛 Markdownlint (0.37.0)
README.md

243-243: null
Spaces inside code span elements

(MD038, no-space-in-code)


250-250: null
Link fragments should be valid

(MD051, link-fragments)


295-295: null
Link fragments should be valid

(MD051, link-fragments)


337-337: null
Link fragments should be valid

(MD051, link-fragments)


409-409: null
Bare URL used

(MD034, no-bare-urls)


414-414: null
Bare URL used

(MD034, no-bare-urls)


420-420: null
Bare URL used

(MD034, no-bare-urls)


425-425: null
Bare URL used

(MD034, no-bare-urls)


427-427: null
Bare URL used

(MD034, no-bare-urls)


433-433: null
Bare URL used

(MD034, no-bare-urls)


438-438: null
Bare URL used

(MD034, no-bare-urls)


443-443: null
Images should have alternate text (alt text)

(MD045, no-alt-text)


473-473: null
Images should have alternate text (alt text)

(MD045, no-alt-text)


481-481: null
Images should have alternate text (alt text)

(MD045, no-alt-text)


522-522: null
No space after hash on atx style heading

(MD018, no-missing-space-atx)

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build

Copy link
Contributor

@paularamo paularamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benjaminpkane It looks very nice! Thanks

@paularamo paularamo merged commit e1f6947 into develop Jan 7, 2025
10 checks passed
@paularamo paularamo deleted the readme-pass branch January 7, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants