-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v1.2.0 #5306
Release/v1.2.0 #5306
Changes from 250 commits
4b1d9ca
dcdfc89
9078679
c52e31a
a478f5c
988d345
bb95534
b60873f
9802e0b
6179687
d4fc848
fa9b104
d0f2abd
7e41330
afefca8
2c7aa31
8f480ac
3c8796e
1f28dca
5972024
476e534
3aaff99
69f60d3
5fcacd0
d7a39e7
8d09f0f
9fe5978
f23d634
84ba847
653555a
8967291
7b89cb3
f427d46
31a53b9
bd9fa59
5ccc01c
e8f0c72
4608a23
83e4f4a
653badf
fd2fb03
bb596d5
24b5ea8
f677604
229296b
c981c49
252961c
401c7ca
02ee83f
52bde0e
c9f7688
9b7786b
374f1a0
16a4daf
e1bc513
62763c8
47bdece
8b41361
6125f1d
eac83ce
f7a79a5
2949c29
15e7ece
ebf8784
3246d80
8593a1a
29c03fa
bc9abe8
ac2b63a
209932b
c91d265
e991eab
11fbcb0
e73409b
3f74b15
7785ecd
0d6dfa0
4dfcb6f
dbbd0b6
fe02666
e39b3f8
88891c4
92cd40c
1f912a9
43d4e47
f3604d5
e9c9a8c
a39b773
178aef4
a7fc52c
9351dc1
d4b81bb
6a5b17f
997bc69
bdc3570
611234d
e204af7
2fdbb38
6608021
6e4775a
53efcf3
7e00596
3f30521
e29f140
6cfce47
6cb954e
fcc480e
e428200
997828d
4ea1df5
4a0cf06
e28dce4
c55387a
35cceee
00d7381
bc9ba41
0fcedd1
b732e20
1a0331a
a56869c
60f8a9a
5c4f9f9
bd748ab
ae916df
3fc9d74
80039dd
781a4f1
0e347ff
e62c1d1
48c52c4
5834afc
882f5aa
532fe7b
f65aa4d
8a72af6
87bf17c
a992ac4
a82749d
3b0ccf6
7d5d7c6
5e32142
abc6a13
28e2ab5
835ccec
3ae877c
4867bd5
a16fb12
a6b5481
a31a55a
eff1e1e
1649f2f
ab58bfb
0b3d92e
e54956c
5c839d7
927b02d
2ca611a
3f5a6b0
5047312
6c894e4
1221190
8820555
224c617
f8d5d8b
ea8b36f
fe56fb3
d367c15
0948c7c
42c6b18
81db334
1594990
0a86bcf
867fc3b
d626e60
6766a55
9fae650
c4df037
68eb682
8331661
038138e
ece501a
89fea41
d3bf174
4f76488
1510b47
e22b56e
73da3ae
b0388a2
d570937
e48511d
d83c00a
64cf79b
686be45
8da1243
568da8a
d41fffc
f627b82
981c42d
a9ea1c3
35f15b2
8997a39
7c51825
4cdeff0
09bb793
a78dd41
1ddd2bf
f704079
9c3cb74
bd7d2de
d0462b9
89d1853
d2038b0
cd8eaee
5d6f683
bc44e3e
d9e5f38
3d5bd81
d872a3b
4fdcc9c
ec2c2e8
2115658
5603258
ae494a5
01807ac
b86906a
b4acf0f
d9649c3
94c3fe9
c82bb81
75d31dc
4bcc45d
b92e747
f254567
79349af
9f78594
91a8e95
d725315
585411c
01c11cc
e5cd1bd
4953b31
fd08265
4e04f98
45a8a28
50970e9
e556b7e
004687a
b9ab1be
e5771c6
41bfd4d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,7 +52,6 @@ | |
], | ||
"packageManager": "[email protected]", | ||
"dependencies": { | ||
"jpeg-js": "^0.4.4", | ||
"react-player": "^2.16.0", | ||
"react-plotly.js": "^2.6.0" | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import { West } from "@mui/icons-material"; | ||
import { Box, Button, Card, Stack, Typography } from "@mui/material"; | ||
import React from "react"; | ||
import ErrorIcon from "./ErrorIcon"; | ||
|
||
export default function Error(props: ErrorProps) { | ||
const { onBack } = props; | ||
return ( | ||
<Stack sx={{ height: "100%", p: 2 }} spacing={1}> | ||
<Box> | ||
<Button onClick={onBack} startIcon={<West />} color="secondary"> | ||
Back to Model Evaluation | ||
</Button> | ||
</Box> | ||
<Card | ||
sx={{ | ||
display: "flex", | ||
justifyContent: "center", | ||
alignItems: "center", | ||
height: "100%", | ||
}} | ||
> | ||
<Stack spacing={2} sx={{ alignItems: "center" }}> | ||
<ErrorIcon sx={{ fontSize: 64 }} /> | ||
<Typography color="secondary"> | ||
Analyze and improve models collaboratively with your team | ||
</Typography> | ||
<Typography sx={{ fontWeight: 600 }}> | ||
The Model Evaluation panel currently supports only classification, | ||
detection, and segmentation evaluations | ||
</Typography> | ||
</Stack> | ||
</Card> | ||
</Stack> | ||
); | ||
} | ||
Comment on lines
+6
to
+36
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Rename component and improve accessibility
Suggested improvements: -export default function Error(props: ErrorProps) {
+export default function EvaluationError(props: ErrorProps) {
const { onBack } = props;
return (
<Stack sx={{ height: "100%", p: 2 }} spacing={1}>
<Box>
<Button
onClick={onBack}
startIcon={<West />}
color="secondary"
+ aria-label="Return to model evaluation"
>
- Back to Model Evaluation
+ {t('modelEvaluation.backButton')}
</Button>
</Box>
{/* ... rest of the component ... */}
</Stack>
);
} Consider creating a separate translations file for all text strings.
🧰 Tools🪛 Biome (1.9.4)[error] 6-6: Do not shadow the global "Error" property. Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global. (lint/suspicious/noShadowRestrictedNames) |
||
|
||
type ErrorProps = { | ||
onBack: () => void; | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
import { SvgIcon, SvgIconProps } from "@mui/material"; | ||
import React from "react"; | ||
|
||
export default function ErrorIcon(props: SvgIconProps) { | ||
return ( | ||
<SvgIcon width="54" height="61" viewBox="0 0 54 61" fill="none" {...props}> | ||
<path | ||
d="M27 3.16667C34.0667 3.16667 40.6667 3.9 45.5334 5.23333C48.4667 6.03333 50 6.83333 50.6667 7.3V53.7C50.0667 54.1667 48.5334 54.9667 45.5334 55.7667C40.6667 57.1 34.0667 57.8333 27 57.8333C19.9334 57.8333 13.3334 57.1 8.46669 55.7667C5.53335 54.9667 4.00002 54.1667 3.33335 53.7V7.3C3.93335 6.83333 5.46669 6.03333 8.46669 5.23333C13.3334 3.9 19.9334 3.16667 27 3.16667ZM27 0.5C19.7334 0.5 12.8667 1.23333 7.73335 2.63333C2.86669 3.96667 0.666687 5.56667 0.666687 6.56667V54.4333C0.666687 55.4333 2.86669 57.0333 7.73335 58.3667C12.8667 59.7 19.7334 60.5 27 60.5C34.2667 60.5 41.1334 59.7 46.2667 58.3667C51.1334 57.0333 53.3334 55.4333 53.3334 54.4333V6.56667C53.3334 5.56667 51.1334 3.96667 46.2667 2.63333C41.1334 1.23333 34.2667 0.5 27 0.5Z" | ||
fill="#FFC59B" | ||
/> | ||
<path | ||
d="M18.2664 27.6333C14.3331 27.6333 11.0664 24.4333 11.0664 20.4333C11.0664 16.4333 14.3331 13.2999 18.2664 13.2999C22.1997 13.2999 25.3997 16.4999 25.3997 20.4333C25.3997 24.3666 22.1997 27.6333 18.2664 27.6333ZM18.2664 15.9666C15.7997 15.9666 13.7331 17.9666 13.7331 20.4999C13.7331 23.0333 15.7331 25.0333 18.2664 25.0333C20.7997 25.0333 22.7997 23.0333 22.7997 20.4999C22.7997 17.9666 20.7331 15.9666 18.2664 15.9666Z" | ||
fill="#FFC59B" | ||
/> | ||
<path | ||
d="M35.7332 27.6333C31.7999 27.6333 28.5332 24.4333 28.5332 20.4333C28.5332 16.4333 31.7332 13.2333 35.7332 13.2333C39.7332 13.2333 42.9332 16.4999 42.9332 20.4333C42.9332 24.3666 39.6665 27.6333 35.7332 27.6333ZM35.7332 15.9666C33.2665 15.9666 31.1999 17.9666 31.1999 20.4999C31.1999 23.0333 33.1999 25.0333 35.7332 25.0333C38.2665 25.0333 40.2665 23.0333 40.2665 20.4999C40.2665 17.9666 38.1999 15.9666 35.7332 15.9666Z" | ||
fill="#FFC59B" | ||
/> | ||
<path | ||
d="M18.2666 21.9C19.0766 21.9 19.7332 21.2434 19.7332 20.4333C19.7332 19.6233 19.0766 18.9667 18.2666 18.9667C17.4565 18.9667 16.7999 19.6233 16.7999 20.4333C16.7999 21.2434 17.4565 21.9 18.2666 21.9Z" | ||
fill="#FFC59B" | ||
/> | ||
<path | ||
d="M35.7334 21.9C36.5434 21.9 37.2 21.2434 37.2 20.4333C37.2 19.6233 36.5434 18.9667 35.7334 18.9667C34.9233 18.9667 34.2667 19.6233 34.2667 20.4333C34.2667 21.2434 34.9233 21.9 35.7334 21.9Z" | ||
fill="#FFC59B" | ||
/> | ||
<path | ||
d="M20.7333 41.2333C20.9333 40.9666 21.6 40.8333 21.9333 40.7666C22.5333 40.7 22.9333 40.9666 23.2 41.5C23.9333 43.0333 26.2666 41.7 25.5333 40.1666C24.2666 37.6333 19.9333 37.3666 18.4666 39.9C17.5333 41.4333 19.8666 42.7666 20.7333 41.2333Z" | ||
fill="#FFC59B" | ||
/> | ||
</SvgIcon> | ||
); | ||
} |
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -1,13 +1,25 @@ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
import { MuiButton } from "@fiftyone/components"; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
import { Add } from "@mui/icons-material"; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
import { Box } from "@mui/material"; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
import React from "react"; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
export default function Evaluate(props: EvaluateProps) { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
const { onEvaluate } = props; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
const { onEvaluate, permissions } = props; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
const canEvaluate = permissions.can_evaluate; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
return ( | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
<MuiButton onClick={onEvaluate} startIcon={<Add />} variant="contained"> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Evaluate Model | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
</MuiButton> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
<Box | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
title={canEvaluate ? "" : "You do not have permission to evaluate model"} | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
sx={{ cursor: canEvaluate ? "pointer" : "not-allowed" }} | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
<MuiButton | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
onClick={onEvaluate} | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
startIcon={<Add />} | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
variant="contained" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
disabled={!canEvaluate} | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Evaluate Model | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
</MuiButton> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
</Box> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Comment on lines
+10
to
+22
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Improve accessibility for disabled state The component should have improved accessibility for screen readers: <Box
title={canEvaluate ? "" : "You do not have permission to evaluate model"}
- sx={{ cursor: canEvaluate ? "pointer" : "not-allowed" }}
+ sx={{ cursor: canEvaluate ? "pointer" : "not-allowed" }}
+ role="region"
+ aria-label="Model evaluation controls"
>
<MuiButton
onClick={onEvaluate}
startIcon={<Add />}
variant="contained"
disabled={!canEvaluate}
+ aria-disabled={!canEvaluate}
>
Evaluate Model
</MuiButton>
</Box> 📝 Committable suggestion
Suggested change
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
); | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Pin the FFmpeg action to commit
f8748f5b0c83db7d0adb3b874893a8c5ff39bda4
The current
@main
reference points to a stable commit from December 10, 2024, which specifically adds retry functionality. Pin to this specific commit SHA for better stability while waiting for the upstream issue to be resolved..github/workflows/e2e.yml
fromafoley587/setup-ffmpeg@main
toafoley587/setup-ffmpeg@f8748f5b0c83db7d0adb3b874893a8c5ff39bda4
🔗 Analysis chain
Consider pinning the FFmpeg action to a specific version
While this is a temporary solution, using
@main
tag for GitHub Actions can be risky as it may lead to unexpected breaking changes. Consider pinning to a specific commit SHA for better stability until the upstream issue is resolved.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 816