-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): AS-359 Update Ubuntu24 Binaries For MongoDB #5269
Conversation
WalkthroughThe pull request updates the workflow configuration for testing in Changes
Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/test.yml
(2 hunks)package/db/setup.py
(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/test.yml
33-33: label "ubuntu-24.04-m" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🔇 Additional comments (1)
package/db/setup.py (1)
127-128
: LGTM! Verify MongoDB 8.0.4 compatibility
The update to MongoDB 8.0.4 binaries for Ubuntu 24.04 is correctly implemented for both architectures. This aligns with the PR objective as MongoDB 7 is not supported on Ubuntu 24.04.
Let's verify the MongoDB binary URLs are accessible:
✅ Verification successful
MongoDB 8.0.4 binary URLs for Ubuntu 24.04 are accessible
Both aarch64 and x86_64 binary URLs for MongoDB 8.0.4 on Ubuntu 24.04 are confirmed to be accessible and valid.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify MongoDB binary URLs for Ubuntu 24.04 are accessible
echo "Checking MongoDB binary URLs for Ubuntu 24.04..."
urls=(
"https://fastdl.mongodb.org/linux/mongodb-linux-aarch64-ubuntu2404-8.0.4.tgz"
"https://fastdl.mongodb.org/linux/mongodb-linux-x86_64-ubuntu2404-8.0.4.tgz"
)
for url in "${urls[@]}"; do
if curl --output /dev/null --silent --head --fail "$url"; then
echo "✓ $url is accessible"
else
echo "✗ $url is not accessible"
fi
done
Length of output: 955
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's how that works...
There may be a doc change somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What changes are proposed in this pull request?
Ubuntu24 does not support mongo 7, we should use the supported mongo 8 binaries for Ubuntu24.
How is this patch tested? If it is not, please explain why.
Testing via github actions on an
ubuntu-24
machine.Actions On Ubuntu24
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
This change updates the
fiftyone-db
mongo binaries from version 7 to version 8. The current binaries that are insetup.py
for ubuntu 24 are actually ubuntu 22 binaries and, therefore, don't work as expected.What areas of FiftyOne does this PR affect?
fiftyone
Python library changesSummary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes