Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): AS-359 Update Ubuntu24 Binaries For MongoDB #5269

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

afoley587
Copy link
Member

@afoley587 afoley587 commented Dec 13, 2024

What changes are proposed in this pull request?

Ubuntu24 does not support mongo 7, we should use the supported mongo 8 binaries for Ubuntu24.

NOTE
Before merging, revert the runs-on clauses for the -m runners

NOTE
GitHub actions will hard swap ubuntu-latest to Ubuntu24 by January 17th (Issue Here)
We can either target this change for the next release branch or, if this becomes a problem on the release branch, we can change the runs-on attribute for the github actions to be ubuntu-22.04 instead of ubuntu-latest.

How is this patch tested? If it is not, please explain why.

docker run -it --rm ubuntu:24.04


apt-get update && apt-get install wget curl
wget "https://fastdl.mongodb.org/linux/mongodb-linux-aarch64-ubuntu2404-8.0.4.tgz"
tar -xvzf mongodb-linux-aarch64-ubuntu2404-8.0.4.tgz
cd mongodb-linux-aarch64-ubuntu2404-8.0.4/bin
./mongod --version

Testing via github actions on an ubuntu-24 machine.
Actions On Ubuntu24

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

This change updates the fiftyone-db mongo binaries from version 7 to version 8. The current binaries that are in setup.py for ubuntu 24 are actually ubuntu 22 binaries and, therefore, don't work as expected.

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Updated testing workflow to use newer versions of Ubuntu for improved compatibility.
    • Enhanced download URLs for MongoDB binaries to support Ubuntu 24.04.
    • Incremented package version for MongoDB from 1.1.7 to 1.2.0.
  • Bug Fixes

    • Ensured correct fetching of MongoDB binaries for both architectures.

Copy link
Contributor

coderabbitai bot commented Dec 13, 2024

Walkthrough

The pull request updates the workflow configuration for testing in .github/workflows/test.yml by changing the operating systems used for the test-app and test-python jobs to newer versions of Ubuntu. Additionally, it modifies the download URLs for MongoDB binaries in package/db/setup.py to ensure compatibility with Ubuntu 24.04. The changes maintain the existing structure and logic of the workflow and do not affect the specified Python versions or the steps within the jobs.

Changes

File Change Summary
.github/workflows/test.yml Updated test-app to run on ubuntu-latest and test-python matrix OS to ubuntu-24.04-m.
package/db/setup.py Updated MongoDB download URLs for Ubuntu 24.04 in LINUX_DOWNLOADS dictionary and incremented version to 1.2.0.

Possibly related issues

  • [FR] Support Ubuntu 24.04 #4526: This issue proposes support for Ubuntu 24.04, which aligns with the changes made to ensure MongoDB compatibility with this version.

Possibly related PRs

Suggested labels

release

Suggested reviewers

  • findtopher
  • brimoor

Poem

In fields of code, we hop and play,
With Ubuntu's newest, we greet the day.
MongoDB's links now point the way,
To seamless tests, come what may!
A leap for all, let’s cheer hooray! 🐇✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e09e169 and adca20b.

📒 Files selected for processing (1)
  • package/db/setup.py (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • package/db/setup.py

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e7f3edd and 1c29db8.

📒 Files selected for processing (2)
  • .github/workflows/test.yml (2 hunks)
  • package/db/setup.py (1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/test.yml

33-33: label "ubuntu-24.04-m" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

🔇 Additional comments (1)
package/db/setup.py (1)

127-128: LGTM! Verify MongoDB 8.0.4 compatibility

The update to MongoDB 8.0.4 binaries for Ubuntu 24.04 is correctly implemented for both architectures. This aligns with the PR objective as MongoDB 7 is not supported on Ubuntu 24.04.

Let's verify the MongoDB binary URLs are accessible:

✅ Verification successful

MongoDB 8.0.4 binary URLs for Ubuntu 24.04 are accessible

Both aarch64 and x86_64 binary URLs for MongoDB 8.0.4 on Ubuntu 24.04 are confirmed to be accessible and valid.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify MongoDB binary URLs for Ubuntu 24.04 are accessible

echo "Checking MongoDB binary URLs for Ubuntu 24.04..."
urls=(
    "https://fastdl.mongodb.org/linux/mongodb-linux-aarch64-ubuntu2404-8.0.4.tgz"
    "https://fastdl.mongodb.org/linux/mongodb-linux-x86_64-ubuntu2404-8.0.4.tgz"
)

for url in "${urls[@]}"; do
    if curl --output /dev/null --silent --head --fail "$url"; then
        echo "$url is accessible"
    else
        echo "$url is not accessible"
    fi
done

Length of output: 955

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
Copy link
Member

@findtopher findtopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's how that works...

There may be a doc change somewhere?

@afoley587 afoley587 changed the title Update Ubuntu24 Binaries For MongoDB fix(ci): AS-359 Update Ubuntu24 Binaries For MongoDB Dec 13, 2024
Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afoley587 afoley587 merged commit 79b8395 into develop Dec 13, 2024
21 checks passed
@afoley587 afoley587 deleted the afoley/AS-359-verify-ubuntu-24 branch December 13, 2024 16:12
@afoley587 afoley587 mentioned this pull request Jan 10, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants