Allow empty paths aggregation (#4621)

* add no paths test * paths fix
voxel51 · Aug 7, 2024 · 11757a6 · 11757a6
1 parent 62d7577
commit 11757a6
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 0 deletions.
diff --git a/fiftyone/server/aggregations.py b/fiftyone/server/aggregations.py
@@ -114,6 +114,9 @@ async def aggregate_resolver(
     if not form.dataset:
         raise ValueError("Aggregate form missing dataset")
 
+    if not form.paths:
+        return []
+
     view = await _load_view(form, form.slices)
 
     slice_view = None

diff --git a/tests/unittests/server_aggregations_tests.py b/tests/unittests/server_aggregations_tests.py
@@ -34,6 +34,46 @@ class AggregationsQuery(AggregateQuery):
 
 
 class TestGroupModeSidebarCounts(unittest.IsolatedAsyncioTestCase):
+    @drop_async_dataset
+    async def test_empty(self, dataset: fo.Dataset):
+        query = """
+            query Query($form: AggregationForm!) {
+                aggregations(form: $form) {
+                    ... on StringAggregation {
+                        path
+                    }
+                }
+            }
+        """
+
+        result = await execute(
+            schema,
+            query,
+            {
+                "form": {
+                    "dataset": dataset.name,
+                    "extended_stages": {},
+                    "filters": {},
+                    "group_id": None,
+                    "hidden_labels": [],
+                    "index": 0,
+                    "mixed": False,
+                    "paths": [],
+                    "sample_ids": [],
+                    "slice": None,
+                    "slices": None,
+                    "view": [],
+                }
+            },
+        )
+
+        self.assertEqual(
+            result.data,
+            {
+                "aggregations": [],
+            },
+        )
+
     @drop_async_dataset
     async def test_group_mode_sidebar_counts(self, dataset: fo.Dataset):
         _add_samples(dataset)