WIP: allow customization of default visibility of labels from dataset app config #6854
sashankaryalpr.yml
on: pull_request
modified-files
30s
teams
0s
Matrix: test / test-python
build
/
changes
27s
build
/
build
4m 2s
e2e
/
test-e2e
59m 16s
lint
/
eslint
2m 37s
test
/
test-app
2m 59s
all-tests
0s
Annotations
11 errors, 25 warnings, and 1 notice
|
[chromium] › oss/specs/overlays/detection-mask.spec.ts:102:3 › detection-mask › should load all masks fine:
e2e-pw/src/oss/specs/overlays/detection-mask.spec.ts#L112
1) [chromium] › oss/specs/overlays/detection-mask.spec.ts:102:3 › detection-mask › should load all masks fine
Error: Screenshot comparison failed:
5929 pixels (ratio 0.04 of all image pixels) are different.
Expected: /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/overlays/detection-mask.spec.ts-snapshots/grid-detections-chromium-linux.png
Received: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-overlays-detecti-7b08c--should-load-all-masks-fine-chromium/grid-detections-actual.png
Diff: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-overlays-detecti-7b08c--should-load-all-masks-fine-chromium/grid-detections-diff.png
Call log:
- expect.toHaveScreenshot(grid-detections.png) with timeout 5000ms
- verifying given screenshot expectation
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_f6hfo_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- 5929 pixels (ratio 0.04 of all image pixels) are different.
- waiting 100ms before taking screenshot
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_f6hfo_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- captured a stable screenshot
- 5929 pixels (ratio 0.04 of all image pixels) are different.
110 | await modal.close();
111 |
> 112 | await expect(grid.getForwardSection()).toHaveScreenshot(
| ^
113 | "grid-detections.png",
114 | {
115 | animations: "allow",
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/overlays/detection-mask.spec.ts:112:44
|
|
[chromium] › oss/specs/overlays/detection-mask.spec.ts:102:3 › detection-mask › should load all masks fine:
e2e-pw/src/oss/specs/overlays/detection-mask.spec.ts#L112
1) [chromium] › oss/specs/overlays/detection-mask.spec.ts:102:3 › detection-mask › should load all masks fine
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
5929 pixels (ratio 0.04 of all image pixels) are different.
Expected: /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/overlays/detection-mask.spec.ts-snapshots/grid-detections-chromium-linux.png
Received: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-overlays-detecti-7b08c--should-load-all-masks-fine-chromium-retry1/grid-detections-actual.png
Diff: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-overlays-detecti-7b08c--should-load-all-masks-fine-chromium-retry1/grid-detections-diff.png
Call log:
- expect.toHaveScreenshot(grid-detections.png) with timeout 5000ms
- verifying given screenshot expectation
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_f6hfo_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- 5929 pixels (ratio 0.04 of all image pixels) are different.
- waiting 100ms before taking screenshot
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_f6hfo_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- captured a stable screenshot
- 5929 pixels (ratio 0.04 of all image pixels) are different.
110 | await modal.close();
111 |
> 112 | await expect(grid.getForwardSection()).toHaveScreenshot(
| ^
113 | "grid-detections.png",
114 | {
115 | animations: "allow",
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/overlays/detection-mask.spec.ts:112:44
|
|
[chromium] › oss/specs/overlays/detection-mask.spec.ts:102:3 › detection-mask › should load all masks fine:
e2e-pw/src/oss/specs/overlays/detection-mask.spec.ts#L112
1) [chromium] › oss/specs/overlays/detection-mask.spec.ts:102:3 › detection-mask › should load all masks fine
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
5929 pixels (ratio 0.04 of all image pixels) are different.
Expected: /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/overlays/detection-mask.spec.ts-snapshots/grid-detections-chromium-linux.png
Received: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-overlays-detecti-7b08c--should-load-all-masks-fine-chromium-retry2/grid-detections-actual.png
Diff: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-overlays-detecti-7b08c--should-load-all-masks-fine-chromium-retry2/grid-detections-diff.png
Call log:
- expect.toHaveScreenshot(grid-detections.png) with timeout 5000ms
- verifying given screenshot expectation
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_f6hfo_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- 5929 pixels (ratio 0.04 of all image pixels) are different.
- waiting 100ms before taking screenshot
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_f6hfo_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- captured a stable screenshot
- 5929 pixels (ratio 0.04 of all image pixels) are different.
110 | await modal.close();
111 |
> 112 | await expect(grid.getForwardSection()).toHaveScreenshot(
| ^
113 | "grid-detections.png",
114 | {
115 | animations: "allow",
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/overlays/detection-mask.spec.ts:112:44
|
|
[chromium] › oss/specs/overlays/detection-mask.spec.ts:102:3 › detection-mask › should load all masks fine:
e2e-pw/src/oss/specs/overlays/detection-mask.spec.ts#L112
1) [chromium] › oss/specs/overlays/detection-mask.spec.ts:102:3 › detection-mask › should load all masks fine
Retry #3 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
5929 pixels (ratio 0.04 of all image pixels) are different.
Expected: /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/overlays/detection-mask.spec.ts-snapshots/grid-detections-chromium-linux.png
Received: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-overlays-detecti-7b08c--should-load-all-masks-fine-chromium-retry3/grid-detections-actual.png
Diff: /home/runner/work/fiftyone/fiftyone/e2e-pw/test-results/oss-specs-overlays-detecti-7b08c--should-load-all-masks-fine-chromium-retry3/grid-detections-diff.png
Call log:
- expect.toHaveScreenshot(grid-detections.png) with timeout 5000ms
- verifying given screenshot expectation
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_f6hfo_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- 5929 pixels (ratio 0.04 of all image pixels) are different.
- waiting 100ms before taking screenshot
- waiting for getByTestId('fo-grid').getByTestId('spotlight-section-forward')
- locator resolved to <div data-cy="spotlight-section-forward" class="_spotlightContainer_f6hfo_19">…</div>
- taking element screenshot
- waiting for fonts to load...
- fonts loaded
- attempting scroll into view action
- waiting for element to be stable
- captured a stable screenshot
- 5929 pixels (ratio 0.04 of all image pixels) are different.
110 | await modal.close();
111 |
> 112 | await expect(grid.getForwardSection()).toHaveScreenshot(
| ^
113 | "grid-detections.png",
114 | {
115 | animations: "allow",
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/overlays/detection-mask.spec.ts:112:44
|
|
[chromium] › oss/specs/regression-tests/index-page.spec.ts:24:1 › index page:
e2e-pw/src/oss/specs/regression-tests/index-page.spec.ts#L1
2) [chromium] › oss/specs/regression-tests/index-page.spec.ts:24:1 › index page ──────────────────
Test timeout of 60000ms exceeded.
|
|
[chromium] › oss/specs/regression-tests/index-page.spec.ts:24:1 › index page:
e2e-pw/src/oss/poms/page.ts#L37
2) [chromium] › oss/specs/regression-tests/index-page.spec.ts:24:1 › index page ──────────────────
Error: page.waitForSelector: Test timeout of 60000ms exceeded.
Call log:
- waiting for locator('[data-cy=index-page]') to be visible
at oss/poms/page.ts:37
35 | await this.datasetSelector.selectResult(dataset);
36 | }
> 37 | await this.page.waitForSelector(
| ^
38 | `[data-cy=${dataset ? "dataset" : "index"}-page]`,
39 | {
40 | state: "visible",
at PagePom.loadDataset (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/page.ts:37:21)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/regression-tests/index-page.spec.ts:25:3
|
|
[chromium] › oss/specs/regression-tests/index-page.spec.ts:24:1 › index page:
e2e-pw/src/oss/specs/regression-tests/index-page.spec.ts#L1
2) [chromium] › oss/specs/regression-tests/index-page.spec.ts:24:1 › index page ──────────────────
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Test timeout of 60000ms exceeded.
|
|
[chromium] › oss/specs/regression-tests/index-page.spec.ts:24:1 › index page:
e2e-pw/src/oss/poms/page.ts#L37
2) [chromium] › oss/specs/regression-tests/index-page.spec.ts:24:1 › index page ──────────────────
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: page.waitForSelector: Test timeout of 60000ms exceeded.
Call log:
- waiting for locator('[data-cy=index-page]') to be visible
at oss/poms/page.ts:37
35 | await this.datasetSelector.selectResult(dataset);
36 | }
> 37 | await this.page.waitForSelector(
| ^
38 | `[data-cy=${dataset ? "dataset" : "index"}-page]`,
39 | {
40 | state: "visible",
at PagePom.loadDataset (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/page.ts:37:21)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/regression-tests/index-page.spec.ts:25:3
|
|
[chromium] › oss/specs/regression-tests/index-page.spec.ts:24:1 › index page:
e2e-pw/src/oss/specs/regression-tests/index-page.spec.ts#L1
2) [chromium] › oss/specs/regression-tests/index-page.spec.ts:24:1 › index page ──────────────────
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Test timeout of 60000ms exceeded.
|
|
[chromium] › oss/specs/regression-tests/index-page.spec.ts:24:1 › index page:
e2e-pw/src/oss/poms/page.ts#L37
2) [chromium] › oss/specs/regression-tests/index-page.spec.ts:24:1 › index page ──────────────────
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: page.waitForSelector: Test timeout of 60000ms exceeded.
Call log:
- waiting for locator('[data-cy=index-page]') to be visible
at oss/poms/page.ts:37
35 | await this.datasetSelector.selectResult(dataset);
36 | }
> 37 | await this.page.waitForSelector(
| ^
38 | `[data-cy=${dataset ? "dataset" : "index"}-page]`,
39 | {
40 | state: "visible",
at PagePom.loadDataset (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/page.ts:37:21)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/regression-tests/index-page.spec.ts:25:3
|
|
all-tests
Process completed with exit code 1.
|
|
modified-files
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
build / changes
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
lint / eslint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L43
React Hook useEffect has missing dependencies: 'panelId', 'panelName', 'props.onUnLoad', 'setPanelCloseEffect', 'trackEvent', and 'triggerPanelEvent'. Either include them or remove the dependency array
|
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L108
React Hook useEffect has a missing dependency: 'dimensions'. Either include it or remove the dependency array
|
|
lint / eslint:
app/packages/operators/src/built-in-operators.ts#L820
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
|
lint / eslint
'path' is never reassigned. Use 'const' instead
|
|
lint / eslint
'value' is never reassigned. Use 'const' instead
|
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
|
test / test-app
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
test / test-python (ubuntu-latest-m, 3.9)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test / test-python (ubuntu-latest-m, 3.10)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test / test-python (ubuntu-latest-m, 3.11)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Slow Test:
e2e-pw/[chromium] › oss/specs/smoke-tests/field-visibility.spec.ts#L1
e2e-pw/[chromium] › oss/specs/smoke-tests/field-visibility.spec.ts took 3.8m
|
|
Slow Test:
e2e-pw/[chromium] › oss/specs/smoke-tests/saved-views.spec.ts#L1
e2e-pw/[chromium] › oss/specs/smoke-tests/saved-views.spec.ts took 1.4m
|
|
Slow Test:
e2e-pw/[chromium] › oss/specs/selection.spec.ts#L1
e2e-pw/[chromium] › oss/specs/selection.spec.ts took 1.3m
|
|
Slow Test:
e2e-pw/[chromium] › oss/specs/operators/prompt.spec.ts#L1
e2e-pw/[chromium] › oss/specs/operators/prompt.spec.ts took 1.1m
|
|
Slow Test:
e2e-pw/[chromium] › oss/specs/sidebar/sidebar-cifar.spec.ts#L1
e2e-pw/[chromium] › oss/specs/sidebar/sidebar-cifar.spec.ts took 39.9s
|
|
e2e / test-e2e
Unexpected input(s) 'working-directory', valid inputs are ['path', 'key', 'restore-keys', 'upload-chunk-size', 'enableCrossOsArchive', 'fail-on-cache-miss', 'lookup-only', 'save-always']
|
|
e2e / test-e2e
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
all-tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
🎭 Playwright Run Summary
8 failed
[chromium] › oss/specs/overlays/detection-mask.spec.ts:102:3 › detection-mask › should load all masks fine
[chromium] › oss/specs/regression-tests/index-page.spec.ts:24:1 › index page ───────────────────
[chromium] › oss/specs/sidebar/sidebar.spec.ts:31:3 › sidebar-filter-visibility › In grid, select a label filter works
[chromium] › oss/specs/sidebar/sidebar.spec.ts:87:3 › sidebar-filter-visibility › In grid, exclude a label filter works
[chromium] › oss/specs/sidebar/sidebar.spec.ts:145:3 › sidebar-filter-visibility › In grid, show samples with a label filter works
[chromium] › oss/specs/sidebar/sidebar.spec.ts:203:3 › sidebar-filter-visibility › In grid, omit samples with a label filter works
[chromium] › oss/specs/smoke-tests/tagger.spec.ts:41:3 › tag › sample tag and label tag loads correct aggregation number on default view
[chromium] › oss/specs/smoke-tests/tagger.spec.ts:78:3 › tag › In grid, I can add a new label tag to all samples
13 flaky
[chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › pcd dynamic group pagination bar ───
[chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › png dynamic group pagination bar ───
[chromium] › oss/specs/groups/nested-dynamic-groups.spec.ts:116:1 › dynamic groups of groups works
[chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › mp4 second slice ────────────────────
[chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › png second slice ────────────────────
[chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:87:3 › groups video labels › video plays with correct label for each slice
[chromium] › oss/specs/smoke-tests/embeddings.spec.ts:62:3 › embeddings on quickstart dataset › lasso samples work
[chromium] › oss/specs/smoke-tests/quickstart-groups.spec.ts:79:5 › quickstart-groups › modal › navigation works
[chromium] › oss/specs/smoke-tests/quickstart-groups.spec.ts:104:5 › quickstart-groups › modal › group media visibility toggle works
[chromium] › oss/specs/smoke-tests/quickstart-groups.spec.ts:139:3 › quickstart-groups › modal with grid filter
[chromium] › oss/specs/smoke-tests/quickstart.spec.ts:36:3 › quickstart › smoke ────────────────
[chromium] › oss/specs/smoke-tests/quickstart.spec.ts:63:3 › quickstart › entry counts text when toPatches then groupedBy
[chromium] › oss/specs/smoke-tests/quickstart.spec.ts:80:3 › quickstart › selection bookmark ───
2 skipped
83 passed (52.5m)
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
dist
|
19.7 MB |
|
|
playwright-report
|
430 MB |
|