fix: read full response message before decoding #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What a timing - a couple of hours ago the same fix was merged into main :D Duplicate of #10 |
Frank-Buss
reviewed
Jun 30, 2023
There was a problem hiding this comment.
Sorry, I fixed it already a week ago, but was only recently reviewed. I like my version better, because it checks for the second 4, 20 marker only after the first line was received, but the rest is basically the same. But I like your new read_until_newline function, and the removal of \r if some server sends this. If you change your PR and integrate your new function and the \r removal into the current version, I'll merge it.
|
PS: I'm currently not working on #8 , might start with it in a few weeks (I'll add a comment then there), if you want something challenging and if you have a nRF dev kit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the full response message before decoding CBOR