very WIP: expand dump-command for subcription things, like template rendering #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO:
* --wait is actually always on now for dump-command, which is wrong
* the dump (see FIXME) is what makes this work at all, and we should be handling it cleanly. The code below it that ends in "didn't expect" has cases where it is entirely silent (type==event without event_typestate_changed)
* DoCommand may get confused from some async event that happens to come in at the wrong time
* perhaps we want the ability for front-cli to subscribe to the id of the command it sent
example command:
build/client-cli dump-command --wait render_template '{ "template":"{{ states(\"fan.ceiling_fan\") }} xx", "timeout": 3}'
Habbie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please read commit messages for status :)