Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uicomponents #35

Merged
merged 19 commits into from
Jan 21, 2024
Merged

Uicomponents #35

merged 19 commits into from
Jan 21, 2024

Conversation

cyclops1982
Copy link
Collaborator

This adds:

  • a UIEntity base class
  • 2 very basic uientity subclasses (UIBUtton and UISwitch)
  • An observer/subject interface so that HAEntity can notify the UIentity of any updates
  • Moves the client-lvgl to a list of button/switch controls in a flexbox
  • removes the uithread_refresh stuff and move over to the observer pattern where needed
  • cleans up some of the stuff we don't need anymore due to the above changes.

@cyclops1982
Dump
33379b6
@cyclops1982
Doesn't work.
6c7db64
@cyclops1982
Make it 'work'
b36a350
@cyclops1982
UISwitch -> UIButton and make it toggle (not based on state)
58a6075
@cyclops1982
Add UISwitch which is a real toggle thing, move the event handler out…
736b02a 
…side UIButton
@cyclops1982
NOT WORKING - Observer pattern so UI can update based on HAentity
46e418c 
This doesn't work because i'm a c++ n00b and struggle with interfaces/abstract classes.

The idea here is that we use IObserver to observe the HAEntity, which then tells us that we need to update the UI according to the new 'state'.
@cyclops1982
Make observer work, disable some debugging.
72cf900 
Initial state not working yet.
@cyclops1982
Fix initial state & remove some other things
207a113
@cyclops1982
Cleanup
5841e72
@cyclops1982
Move to set<> for observers
8df3927
@cyclops1982
Move to unique_ptr for UIEntity
91107ac
@cyclops1982
uicomponent seperated in hpp/cpp
1d3d22f
@cyclops1982
change client-cli's subscribe to a domain subcribe using observer pat…
d50c5c1 
…tern

NOT WORKING!
@cyclops1982
Make it work with a pointer?! - rename client-lvgl in the command line
14b96d8
@cyclops1982
ChatGPT made it work.
6900595
@cyclops1982
Cleanup uithread_refresh and other things
7179895
@cyclops1982
Unique_ptr according to chatgpt
54be1ac
@cyclops1982
More auto const& and cleanup
56a48ff
@cyclops1982
Move click-handlers into the class
bc9657e
@Habbie
Copy link
Member

Habbie commented Jan 21, 2024

tested all 3 frontends, merging!

@Habbie Habbie merged commit f6eab33 into voorkant:main Jan 21, 2024
3 checks passed
Habbie
Habbie reviewed Jan 22, 2024
View reviewed changes
src/HAEntity.cpp Show resolved Hide resolved
src/UIComponents.cpp Show resolved Hide resolved
src/UIComponents.cpp Show resolved Hide resolved
src/UIComponents.cpp Show resolved Hide resolved
src/UIComponents.cpp Show resolved Hide resolved
@cyclops1982 cyclops1982 mentioned this pull request Jan 22, 2024
Merged
@cyclops1982 cyclops1982 deleted the uicomponents branch December 5, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Habbie Habbie Habbie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyclops1982 @Habbie