Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

force build-ubuntu to 24.04 #119

Merged
merged 1 commit into from
Oct 4, 2024
Merged

force build-ubuntu to 24.04 #119

merged 1 commit into from
Oct 4, 2024

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Oct 4, 2024

No description provided.

@Habbie Habbie force-pushed the ubuntu-runner-24.04 branch from 6738b7e to 5ed5165 Compare October 4, 2024 17:06
@Habbie Habbie requested a review from cyclops1982 October 4, 2024 17:06
cyclops1982
cyclops1982 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@cyclops1982 cyclops1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed meson coming from ubuntu and not from pip. This is ok because people will use different meson versions anyway.

@Habbie
Copy link
Member Author

Habbie commented Oct 4, 2024

We discussed meson coming from ubuntu and not from pip. This is ok because people will use different meson versions anyway.

we should put a minimum version in there at some point perhaps, but indeed

@Habbie Habbie merged commit 05f33f6 into voorkant:main Oct 4, 2024
4 checks passed
@Habbie Habbie deleted the ubuntu-runner-24.04 branch October 4, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyclops1982 cyclops1982 cyclops1982 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Habbie @cyclops1982