use B612 Regular size 16 for logbox #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no longer slow. Now contains #116, will need a kick after that one is merged. Then we can put the font in more places (or another font, or make it configurable, or ...) |
cyclops1982
approved these changes
Oct 2, 2024
Habbie
changed the title
Habbie
commented
Oct 4, 2024
There was a problem hiding this comment.
I'm happy with this PR now. I'd like to squash a few things - primarily, remove the .ttf from history so it doesn't take up space. Secondary, we have a few commits that do and then undo things, might as well have zero instead. Will do that cleanup after @cyclops1982 reviewed.
.github/workflows/main.yml
Outdated
| @@ -17,7 +17,7 @@ jobs: | |||
| - name: Update apt indexes | |||
| run: sudo apt-get update | |||
| - name: Install various apt dependencies | |||
| run: sudo apt-get install build-essential cmake ninja-build nlohmann-json3-dev pkg-config libssl-dev libsdl2-dev python3-pip | |||
| run: sudo apt-get install build-essential cmake ninja-build nlohmann-json3-dev pkg-config libssl-dev libsdl2-dev python3-pip xxd | |||
There was a problem hiding this comment.
just a note (to self perhaps), we should make this one package per line, sorted, so diffs are easier to read
cyclops1982
approved these changes
Oct 5, 2024
Habbie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRing this just to have it saved somewhere. the tiny TTF engine is extremely slow for our logbox, not sure why. It might be fine for other things, which is easy to test on top of this PR.
voorkant-lvgl now expects the .ttf file to be in the working directory, which is not what we want either.