Added dataset in JSON format #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 3, 2020 11:17
…oring done 1. Refactor the snippet for max aggregation (i.e., line 86-90) using default dict for a simpler logic https://github.com/vonfeng/DeepMove/blob/0acff5d88d70d31a4fcf580648e0056e103dc6cf/codes/train.py#L86 2. Refactor the snippet for avg aggregation (i.e., line 106-116) using Counter for a simpler logic https://github.com/vonfeng/DeepMove/blob/0acff5d88d70d31a4fcf580648e0056e103dc6cf/codes/train.py#L106 3. Move the assignment of "history_count" inside the if logic to reduce redundancy https://github.com/vonfeng/DeepMove/blob/0acff5d88d70d31a4fcf580648e0056e103dc6cf/codes/train.py#L124 4. Refactor the variable "loc_tim" in "generate_input_long_history2" since it is unnecessary 5. Refactor the history, count extraction, and torch_trace 6. Fixed the indentation for "generate_input_long_history2" 7. Added commentary for foursquare dataset structure
Fixed indentation for generate_input_long_history2 and refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Python 2 is not supported anymore by Jan 2020, some people including myself cannot access the pickled dataset. Moreover, the dataset can only be opened using a Linux environment which may hinder a Windows user to access it. Thus, I created a "JSON" format for the dataset as it might be easier to understand the dataset and because the original data are based on the dictionary of dictionaries, JSON format is suitable for representing them.