fix(typescript): empty items list should be valid completion result

close vuejs/language-tools#4368
volarjs · May 13, 2024 · e5af37a · e5af37a
1 parent 8aa41e4
commit e5af37a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/typescript/lib/node/decorateLanguageService.ts b/packages/typescript/lib/node/decorateLanguageService.ts
@@ -699,7 +699,7 @@ export function decorateLanguageService(language: Language, languageService: ts.
  continue;
  }
  const result = getCompletionsAtPosition(fileName, generatedOffset, options, formattingSettings);
- if (!result || !result.entries.length) {
+ if (!result) {
  continue;
  }
  if (typeof mapping.data.completion === 'object' && mapping.data.completion.onlyImport) {
@@ -715,7 +715,7 @@ export function decorateLanguageService(language: Language, languageService: ts.
  results.push(result);
  }
  else {
- results.splice(0, 0, result);
+ results.unshift(result);
  }
  }
  if (results.length) {