Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Vanilla JS #204

Merged
merged 37 commits into from
Jul 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
49d9a85
refactor(@svelte-put/clickoutside): migration to vanilla JS
Jul 12, 2023
0e41818
refactor(@svelte-put/copy): migration to vanilla JS
Jul 12, 2023
3fa31b7
chore: config turbo dts command
Jul 13, 2023
00a021f
refactor(copy): better naming for parameter type
Jul 13, 2023
4d91a66
chore: upgrade turbo
Jul 13, 2023
b477bd6
refactor(clickoutside): better naming for action parameter type
Jul 13, 2023
6099b20
chore(clickoutside): remove unnecessary export field (package.json)
Jul 13, 2023
a944ea0
refactor(@svelte-put/dragscroll): migration to vanilla JS
Jul 13, 2023
7539b5e
fix: bundle should include types folder
Jul 13, 2023
8a89089
refactor(@svelte-put/intersect): migration to vanilla JS
Jul 13, 2023
c5648ee
refactor(@svelte-put/movable): migration to vanilla JS
Jul 13, 2023
2fbb15f
refactor(@svelte-put/resize): migration to vanilla JS
Jul 13, 2023
1af727b
refactor(@svelte-put/shortcut): migration to vanilla JS
Jul 13, 2023
539919d
refactor(movable): change event detail type naming
Jul 13, 2023
d36f8aa
chore: update top level packages to latest minor
Jul 13, 2023
e68a883
refactor(@svelte-put/inline-svg): migration to vanilla JS
Jul 13, 2023
4218fed
refactor(inline-svg): stop exposing internal utils (package pollution)
Jul 13, 2023
5c6949d
chore(docs): remove api reference for inline-svg package docs
Jul 13, 2023
3c4b066
refactor(@svelte-put/toc): migration to vanilla JS
Jul 13, 2023
de82232
refactor: simplify dts-buddy with builtin cli (rather than node script)
Jul 13, 2023
cf0b498
refactor(clickoutside): include the deprecated types for one more maj…
vnphanquang Jul 14, 2023
0345d83
refactor(copy): include the deprecated types for one more major version
vnphanquang Jul 14, 2023
ef354d3
refactor(dragscroll): include the deprecated types for one more major…
vnphanquang Jul 14, 2023
8133e59
refactor(inline-svg): include the deprecated types for one more major…
vnphanquang Jul 14, 2023
d29aeba
refactor(intersect): include the deprecated types for one more major …
vnphanquang Jul 14, 2023
eb009ff
refactor(movable): include the deprecated types for one more major ve…
vnphanquang Jul 14, 2023
ef49ed8
refactor(resize): include the deprecated types for one more major ver…
vnphanquang Jul 14, 2023
ac3cf51
refactor: move deprecated typedefs to end of file
vnphanquang Jul 14, 2023
85c54cd
refactor(shortcut): include the deprecated types for one more major v…
vnphanquang Jul 14, 2023
9be59c1
refactor(toc): deprecate some types in favor for more consistent naming
vnphanquang Jul 14, 2023
6d98201
refactor(preprocess-helpers): migrate to vanilla JS
vnphanquang Jul 15, 2023
2030954
chore(preprocess-helpers): make publish-able
vnphanquang Jul 15, 2023
e418788
chore(inlin-svg): bump dependencies
vnphanquang Jul 15, 2023
2d742fc
chore(docs): move partytown & gtag script tag out of svelte file to a…
vnphanquang Jul 15, 2023
1032259
chore(docs): fix eslint reports
vnphanquang Jul 15, 2023
f69ec1a
chore: upgrade to svelte 4 and all latest dependencies
vnphanquang Jul 15, 2023
f489c48
fix(docs): return early for gtag check (fails on dev)
vnphanquang Jul 15, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 5 additions & 0 deletions .changeset/blue-jeans-look.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@svelte-put/clickoutside': major
---

migrated to vanilla JS (tracked at #203)
5 changes: 5 additions & 0 deletions .changeset/chilly-cats-hang.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@svelte-put/intersect': major
---

Better naming for action parameter type
5 changes: 5 additions & 0 deletions .changeset/forty-trains-mix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@svelte-put/preprocess-helpers': major
---

Migrated to vanilla JS (tracked #203)
5 changes: 5 additions & 0 deletions .changeset/friendly-vans-walk.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@svelte-put/resize': major
---

Better naming for action parameter type
5 changes: 5 additions & 0 deletions .changeset/fuzzy-rivers-visit.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@svelte-put/resize': major
---

Migrated to vanilla JS (tracked at #203)
5 changes: 5 additions & 0 deletions .changeset/gorgeous-suns-raise.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@svelte-put/dragscroll': major
---

Migrated to vanilla JS (tracked at #203)
5 changes: 5 additions & 0 deletions .changeset/heavy-toys-jog.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@svelte-put/shortcut': major
---

Migrated to vanilla JS (tracked at #203)
5 changes: 5 additions & 0 deletions .changeset/kind-lies-smoke.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@svelte-put/preprocess-inline-svg': patch
---

bump dependencies
5 changes: 5 additions & 0 deletions .changeset/little-cars-push.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@svelte-put/movable': major
---

change `MovableEventDetails` to `MovableEventDetail` (better naming that goes along with `event.detail` api)
5 changes: 5 additions & 0 deletions .changeset/new-geckos-prove.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@svelte-put/inline-svg': major
---

Migrated to vanilla JS (tracked at #203)
5 changes: 5 additions & 0 deletions .changeset/nice-cars-walk.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@svelte-put/inline-svg': major
---

Better naming for typing
5 changes: 5 additions & 0 deletions .changeset/serious-actors-bathe.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@svelte-put/copy': major
---

Better naming for parameter types
5 changes: 5 additions & 0 deletions .changeset/short-moons-collect.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@svelte-put/movable': major
---

Migrated to vanilla JS (tracked at #203)
5 changes: 5 additions & 0 deletions .changeset/silly-tips-divide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@svelte-put/shortcut': major
---

better naming for types
5 changes: 5 additions & 0 deletions .changeset/silver-yaks-stare.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@svelte-put/dragscroll': major
---

Better naming for action parameter type
5 changes: 5 additions & 0 deletions .changeset/sour-cycles-laugh.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@svelte-put/copy': major
---

Migrated to vanilla JS (tracked at #203)
5 changes: 5 additions & 0 deletions .changeset/spotty-yaks-nail.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@svelte-put/inline-svg': major
---

internal utils are no longer exposed (reduce pacakge pollution)
5 changes: 5 additions & 0 deletions .changeset/thirty-socks-tell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@svelte-put/movable': major
---

Better naming for action parameter type
5 changes: 5 additions & 0 deletions .changeset/tidy-coats-pay.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@svelte-put/toc': major
---

Migrated to vanilla JS (tracked at #203)
5 changes: 5 additions & 0 deletions .changeset/warm-comics-repair.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@svelte-put/intersect': major
---

Migrated to vanilla JS (tracked at #203)
5 changes: 5 additions & 0 deletions .changeset/yellow-fans-shop.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@svelte-put/clickoutside': major
---

Better naming for action parameter type
5 changes: 5 additions & 0 deletions .changeset/young-zoos-clean.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@svelte-put/toc': major
---

`DEFAULT_TOC_PARAMETERS` & `DEFAULT_TOC_LINK_PARAMETERS` are no longer exxported
13 changes: 12 additions & 1 deletion .eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -1,8 +1,19 @@
module.exports = {
root: true,
extends: ['@vnphanquang/eslint-config-svelte'],
extends: ['@vnphanquang/eslint-config', 'plugin:svelte/recommended'],
globals: {
App: 'readonly',
gtag: 'readonly',
},
overrides: [
{
files: ['*.svelte'],
parser: 'svelte-eslint-parser',
// Parse the `<script>` in `.svelte` as TypeScript by adding the following configuration.
parserOptions: {
parser: '@typescript-eslint/parser',
},
},
// ...
],
};
2 changes: 1 addition & 1 deletion .github/workflows/changesets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
cache: pnpm
- name: Install dependencies
run: pnpm install --ignore-scripts --no-frozen-lockfile
Expand Down
17 changes: 17 additions & 0 deletions configs/tsconfig/base.package.js.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"$schema": "https://json.schemastore.org/tsconfig",
"compilerOptions": {
"allowJs": true,
"checkJs": true,
"noEmit": true,
"strict": true,
"target": "es2020",
"module": "es2022",
"moduleResolution": "node",
"allowSyntheticDefaultImports": true,
"noUnusedLocals": true,
"noUnusedParameters": true
},
"include": ["src/**/*"],
"exclude": ["node_modules"]
}
3 changes: 2 additions & 1 deletion configs/tsconfig/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"author": "Quang Phan",
"files": [
"base.json",
"base.package.json"
"base.package.json",
"base.package.js.json"
]
}
27 changes: 15 additions & 12 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,28 +19,31 @@
"lint": "turbo run lint --parallel",
"format": "turbo run format --parallel",
"api": "turbo run api",
"dts": "turbo run dts",
"ci:version": "changeset version && pnpm install",
"ci:publish": "pnpm build && changeset publish && pnpm install"
},
"devDependencies": {
"@changesets/changelog-github": "^0.4.8",
"@changesets/cli": "^2.26.1",
"@vnphanquang/eslint-config": "^1.2.3",
"@vnphanquang/eslint-config-svelte": "^1.0.4",
"@changesets/cli": "^2.26.2",
"@types/node": "^20.4.2",
"@vnphanquang/eslint-config": "^2.0.0",
"@vnphanquang/prettierrc": "^1.0.1",
"eslint": "^8.37.0",
"lint-staged": "^13.2.0",
"eslint": "^8.45.0",
"eslint-plugin-svelte": "^2.32.2",
"lint-staged": "^13.2.3",
"postcss-html": "^1.5.0",
"prettier": "^2.8.7",
"prettier-plugin-svelte": "^2.10.0",
"prettier": "^2.8.8",
"prettier-plugin-svelte": "^2.10.1",
"simple-git-hooks": "^2.8.1",
"stylelint": "^15.4.0",
"stylelint-config-clean-order": "^5.0.0",
"stylelint": "^15.10.1",
"stylelint-config-clean-order": "^5.0.1",
"stylelint-config-html": "^1.1.0",
"stylelint-config-standard": "^32.0.0",
"svelte": "^3.58.0",
"turbo": "^1.8.8",
"typescript": "^5.0.3"
"svelte": "^4.0.5",
"tslib": "^2.6.0",
"turbo": "^1.10.7",
"typescript": "^5.1.6"
},
"engines": {
"pnpm": ">=7.5.0",
Expand Down
1 change: 1 addition & 0 deletions packages/actions/clickoutside/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
types/
6 changes: 0 additions & 6 deletions packages/actions/clickoutside/api-extractor.json

This file was deleted.

21 changes: 8 additions & 13 deletions packages/actions/clickoutside/api/clickoutside.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,14 @@

```ts

import type { Action } from 'svelte/action';
import { Action } from 'svelte/action';
import { ActionReturn } from 'svelte/action';

// @public
export const clickoutside: Action<HTMLElement, Partial<ClickOutsideParameters>, ClickOutsideAttributes>;
// @public (undocumented)
export type ClickOutsideAction = Action<HTMLElement, ClickOutsideParameters, ClickOutsideAttributes>;

// @public (undocumented)
export type ClickOutsideActionReturn = ActionReturn<ClickOutsideParameters, ClickOutsideAttributes>;

// @public
export interface ClickOutsideAttributes {
Expand All @@ -28,15 +32,6 @@ export interface ClickOutsideParameters {
options?: AddEventListenerOptions | boolean;
}

// Warning: (ae-internal-missing-underscore) The name "resolveParameters" should be prefixed with an underscore because the declaration is marked as @internal
//
// @internal (undocumented)
export function resolveParameters(parameters: Partial<ClickOutsideParameters>): {
enabled: boolean;
nodeForEvent: HTMLElement | Document;
eventType: string;
options: boolean | AddEventListenerOptions | undefined;
capture: boolean | undefined;
};
// (No @packageDocumentation comment for this package)

```

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<!-- Do not edit this file. It is automatically generated by API Documenter. -->

[Home](./index.md) &gt; [@svelte-put/clickoutside](./clickoutside.md) &gt; [ClickOutsideAction](./clickoutside.clickoutsideaction.md)

## ClickOutsideAction type


**Signature:**

```typescript
export type ClickOutsideAction = Action<HTMLElement, ClickOutsideParameters, ClickOutsideAttributes>;
```
**References:** [ClickOutsideParameters](./clickoutside.clickoutsideparameters.md)<!-- -->, [ClickOutsideAttributes](./clickoutside.clickoutsideattributes.md)

Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<!-- Do not edit this file. It is automatically generated by API Documenter. -->

[Home](./index.md) &gt; [@svelte-put/clickoutside](./clickoutside.md) &gt; [ClickOutsideActionReturn](./clickoutside.clickoutsideactionreturn.md)

## ClickOutsideActionReturn type


**Signature:**

```typescript
export type ClickOutsideActionReturn = ActionReturn<ClickOutsideParameters, ClickOutsideAttributes>;
```
**References:** [ClickOutsideParameters](./clickoutside.clickoutsideparameters.md)<!-- -->, [ClickOutsideAttributes](./clickoutside.clickoutsideattributes.md)

9 changes: 4 additions & 5 deletions packages/actions/clickoutside/api/docs/clickoutside.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

## clickoutside package

`use:clickoutside` - svelte action that emits the `clickoutside` event when the user clicks outside of a node.

## Interfaces

| Interface | Description |
Expand All @@ -14,9 +12,10 @@
| [ClickOutsideLimit](./clickoutside.clickoutsidelimit.md) | Limit to which the click event will trigger <code>clickoutside</code> |
| [ClickOutsideParameters](./clickoutside.clickoutsideparameters.md) | svelte action parameters to config behavior of <code>clickoutside</code> |

## Variables
## Type Aliases

| Variable | Description |
| Type Alias | Description |
| --- | --- |
| [clickoutside](./clickoutside.clickoutside.md) | Dispatch a <code>clickoutside</code> [CustomEvent](https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent) on click outside of node |
| [ClickOutsideAction](./clickoutside.clickoutsideaction.md) | |
| [ClickOutsideActionReturn](./clickoutside.clickoutsideactionreturn.md) | |