Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend/tracing: add fields to span again for error spantrace #567

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

vnghia
Copy link
Owner

@vnghia vnghia commented Dec 11, 2024

No description provided.

@vnghia vnghia changed the title chore: upgrade typed-path to 0.10.0 backend/tracing: add fields to span again for error spantrace Dec 11, 2024
@vnghia vnghia merged commit f7a8825 into main Dec 11, 2024
8 of 11 checks passed
@vnghia vnghia deleted the better-tracing branch December 11, 2024 06:48
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 70.27027% with 11 lines in your changes missing coverage. Please review.

Project coverage is 74.04%. Comparing base (04c753c) to head (7baef23).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
nghe-backend/src/filesystem/path/serde.rs 0.00% 9 Missing ⚠️
nghe-backend/src/filesystem/local.rs 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
+ Coverage   73.01%   74.04%   +1.02%     
==========================================
  Files         184      174      -10     
  Lines        4718     4643      -75     
  Branches     4718     4643      -75     
==========================================
- Hits         3445     3438       -7     
+ Misses        840      783      -57     
+ Partials      433      422      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant