Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: refactor auth from request #551

Merged
merged 7 commits into from
Dec 5, 2024
Merged

backend: refactor auth from request #551

merged 7 commits into from
Dec 5, 2024

Conversation

vnghia
Copy link
Owner

@vnghia vnghia commented Dec 5, 2024

No description provided.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 90.14085% with 21 lines in your changes missing coverage. Please review.

Project coverage is 75.06%. Comparing base (dbb1f9e) to head (2ad5cc6).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
nghe-proc-macro/src/api.rs 93.24% 4 Missing and 1 partial ⚠️
nghe-backend/src/http/extract/auth/mod.rs 80.00% 0 Missing and 3 partials ⚠️
nghe-backend/src/http/extract/binary.rs 80.00% 0 Missing and 3 partials ⚠️
nghe-backend/src/http/extract/auth/form.rs 92.00% 0 Missing and 2 partials ⚠️
nghe-proc-macro/src/backend.rs 95.65% 0 Missing and 2 partials ⚠️
nghe-api/src/auth/form.rs 75.00% 0 Missing and 1 partial ⚠️
nghe-api/src/auth/token.rs 66.66% 0 Missing and 1 partial ⚠️
nghe-api/src/common/format.rs 0.00% 1 Missing ⚠️
nghe-api/src/lists/get_album_list2.rs 0.00% 0 Missing and 1 partial ⚠️
...ghe-api/src/system/get_open_subsonic_extensions.rs 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
- Coverage   79.17%   75.06%   -4.11%     
==========================================
  Files         220      223       +3     
  Lines        5738     6517     +779     
  Branches     5738     6517     +779     
==========================================
+ Hits         4543     4892     +349     
- Misses        789     1163     +374     
- Partials      406      462      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vnghia vnghia merged commit a739759 into main Dec 5, 2024
12 of 13 checks passed
@vnghia vnghia deleted the refactor-from-request branch December 5, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant