Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native cache from actions/setup-go #7768

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented May 4, 2024

Thank you for contributing to Velero!

Please add a summary of your change

Use native cache from actions/setup-go instead of defining actions/cache for ~/go/pkg/mod path

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.67%. Comparing base (a0b7382) to head (d8e7e59).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7768   +/-   ##
=======================================
  Coverage   58.67%   58.67%           
=======================================
  Files         345      345           
  Lines       28739    28739           
=======================================
  Hits        16862    16862           
  Misses      10448    10448           
  Partials     1429     1429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 marked this pull request as ready for review May 4, 2024 21:06
@mmorel-35
Copy link
Contributor Author

/kind changelog-not-required

@mmorel-35 mmorel-35 force-pushed the actions/setup-go branch 4 times, most recently from f65b259 to 75cd29a Compare May 5, 2024 20:27
@mmorel-35 mmorel-35 requested a review from kaovilai May 6, 2024 06:39
@mmorel-35
Copy link
Contributor Author

/kind changelog-not-required

@reasonerjt
Copy link
Contributor

Doesn't have to be in v1.14.0? I'd propose we delay it after v1.14.0 RC

@mmorel-35
Copy link
Contributor Author

Doesn't have to be in v1.14.0?

I agree, no need

@blackpiglet
Copy link
Contributor

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label May 7, 2024
@blackpiglet blackpiglet removed the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label May 7, 2024
@blackpiglet
Copy link
Contributor

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label May 7, 2024
@mmorel-35 mmorel-35 force-pushed the actions/setup-go branch 2 times, most recently from 201aed4 to bb38a28 Compare May 14, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defer-candidate kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants