testifylint: enable compares rule #7671
Merged
+7
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
added
the
kind/changelog-not-required
kaovilai
approved these changes
Apr 16, 2024
mmorel-35
force-pushed
the
testifylint/compare
branch
from
f18e773
to
4868102
Compare
kaovilai
approved these changes
Apr 19, 2024
mmorel-35
force-pushed
the
testifylint/compare
branch
2 times, most recently
from
b92a480
to
6b1f27a
Compare
mmorel-35
force-pushed
the
testifylint/compare
branch
from
6b1f27a
to
87e29ee
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7671 +/- ##
=======================================
Coverage 58.67% 58.67%
=======================================
Files 345 345
Lines 28739 28739
=======================================
Hits 16862 16862
Misses 10448 10448
Partials 1429 1429 ☔ View full report in Codecov by Sentry. |
blackpiglet
previously approved these changes
May 6, 2024
mmorel-35
force-pushed
the
testifylint/compare
branch
from
e322b98
to
142d865
Compare
mmorel-35
force-pushed
the
testifylint/compare
branch
from
142d865
to
c944ff6
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
testifylint/compare
branch
from
c944ff6
to
1010b04
Compare
kaovilai
approved these changes
May 20, 2024
sseago
approved these changes
May 20, 2024
shubham-pampattiwar
approved these changes
May 20, 2024
ccoVeille
reviewed
May 26, 2024
ccoVeille
reviewed
May 26, 2024
blackpiglet
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a summary of your change
testifylint: enable compares rule
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.