PingCastle 2.8.1.0

vletoux · Feb 23, 2020 · 9e237ef · 9e237ef
1 parent a49c7f8
commit 9e237ef
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 11 deletions.
diff --git a/Data/CompromiseGraphData.cs b/Data/CompromiseGraphData.cs
@@ -308,8 +308,9 @@ public class SingleCompromiseGraphNodeData
  public string Name { get; set; }
  [XmlAttribute]
  public string Type { get; set; }
-
- [XmlIgnore]
+
+ [IgnoreDataMember]
+ [XmlIgnore]
  public bool IsTypeAUser
  {
  get
@@ -330,7 +331,8 @@ public bool IsTypeAUser
  public bool Critical { get; set; }
  // used when building the structure
  [XmlIgnore]
- public ADItem ADItem { get; set; }
+ [IgnoreDataMember]
+ internal ADItem ADItem { get; set; }
  }
 
  [XmlType("link")]

diff --git a/Healthcheck/HealthcheckAnalyzer.cs b/Healthcheck/HealthcheckAnalyzer.cs
@@ -3334,10 +3334,10 @@ private void ExtractGPOAudit(string path, GPO GPO, ADDomainInfo domainInfo)
  {
  using (TextReader tr = new StreamReader(path))
  {
- string line = tr.ReadLine();
- // skip first line
- if (line != null)
- line = tr.ReadLine();
+ // skip first line
+ string line = tr.ReadLine();
+ if (line == null)
+ return;
  while ((line = tr.ReadLine()) != null)
  {
  var b = line.Split(',');

diff --git a/Healthcheck/Rules/HeatlcheckRulePrivilegedSchemaAdmins.cs b/Healthcheck/Rules/HeatlcheckRulePrivilegedSchemaAdmins.cs
@@ -21,7 +21,7 @@ public class HeatlcheckRulePrivilegedSchemaAdmins : RuleBase<HealthcheckData>
  {
  foreach (HealthCheckGroupData group in healthcheckData.PrivilegedGroups)
  {
- if (group.GroupName == "Schema Admins")
+ if (group.GroupName == "Schema Administrators")
  {
  if (group.NumberOfMember > 0)
  {

diff --git a/Properties/AssemblyInfo.cs b/Properties/AssemblyInfo.cs
@@ -29,5 +29,5 @@
 // Numéro de build
 // Révision
 //
-[assembly: AssemblyVersion("2.8.0.0")]
-[assembly: AssemblyFileVersion("2.8.0.0")]
+[assembly: AssemblyVersion("2.8.1.0")]
+[assembly: AssemblyFileVersion("2.8.1.0")]
diff --git a/Report/ReportHealthCheckSingle.cs b/Report/ReportHealthCheckSingle.cs
@@ -1097,9 +1097,9 @@ private void GenerateSummary(int index, SingleCompromiseGraphData data)
 
  if (data.Dependancies.Count != 0)
  {
+ Add("<td>");
  for (int i = 0; i < data.Dependancies.Count; i++)
  {
- Add("<td>");
  var d = data.Dependancies[i];
  if (i > 0)
  Add("<br>");