Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields for method "market.get" #1580

Merged

Conversation

Rahovski
Copy link
Contributor

@Rahovski Rahovski commented Aug 21, 2023

List of changes

  • added support for new fields of method market.get - date_from, date_to, need_variants, with_disabled
  • added model MarketGetParams for wrap arguments for method market.get
  • added unit test and test data for thid method

Source of args

Bound with issue #1222

- Added model "MarketGetParams.cs"
- Applied this model to market.get methods
…et model

- change DateTime field type to string because of default constructor
@Rahovski
Copy link
Contributor Author

@Panuchi @inyutin-maxim Request restart github actions, cause it fall on stage to send telegram notification
Link
изображение

@inyutin-maxim inyutin-maxim added the Pull Request Исправление внесенное пользователем не состоящим в основном списке разработчиков label Aug 21, 2023
@inyutin-maxim inyutin-maxim added this to the v1.76.0 milestone Aug 21, 2023
@Rahovski Rahovski temporarily deployed to VkNet August 27, 2023 21:25 — with GitHub Actions Inactive
@Rahovski Rahovski requested a review from inyutin-maxim August 27, 2023 21:30
@inyutin-maxim
Copy link
Member

@Rahovski Please resolve conflicts

@Rahovski Rahovski temporarily deployed to VkNet August 28, 2023 13:35 — with GitHub Actions Inactive
@Rahovski Rahovski requested a review from inyutin-maxim August 28, 2023 13:36
@inyutin-maxim inyutin-maxim temporarily deployed to VkNet August 28, 2023 13:37 — with GitHub Actions Inactive
@inyutin-maxim inyutin-maxim merged commit 2796c74 into vknet:develop Aug 28, 2023
@Rahovski Rahovski deleted the 1222-feature/add-field-to-marketGet branch August 28, 2023 15:44
@Rahovski Rahovski mentioned this pull request Aug 28, 2023
90 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Исправление внесенное пользователем не состоящим в основном списке разработчиков
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants