Dim--dim on x y #526
Merged
Dim--dim on x y #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simzer
reviewed
May 21, 2024
| @@ -115,6 +115,9 @@ void Options::drilldownTo(const Options &other) | |||
| for (auto &&dim : other.getChannels().getDimensions()) | |||
| if (!getChannels().isSeriesUsed(dim)) | |||
| stackChannel.addSeries(dim); | |||
| if (stackChannel.isDimension() | |||
| && geometry == ShapeType::rectangle) | |||
| this->align = Base::Align::Type::stretch; | |||
There was a problem hiding this comment.
It smells a bit "workaroundy". Stretch does the work, but it's purpose is complety different.
I feel like that instead, we would need an bool spacing member in Channel which gives controls to manually swich on/off the spacing.
There was a problem hiding this comment.
I noted. I'll not rewrite it in this PR but handle it at the axis refactor.
simzer
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.