Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phomemo M220 compatibility #15

Closed
wants to merge 3 commits into from
Closed

Conversation

bleriotx
Copy link

Code changes required to get Cups printer filter to work with M220 printer.

  • Removed unneeded printer init codes.
  • Modified the rendering code to send the print job in one sequence.

Modifications to accommodate the M220 printer.
1) Removed code that send printer image on 255 line blocks. Now image is sent in a single block.
2) Removed code that send printer init request since it is not needed.
@vivier
Copy link
Owner

vivier commented Jul 12, 2023

Please remove the code that is unused rather than to comment it out.
Don't add "2023-07-12 bleriotx - Fix for Phomemo M220 printer." in your comment the timestamp and the author are already given by the git log (with "git blame"), and you can put "Fix for Phomemo M220 printer" as the commit message header.
Merge both commits in one.
Did you test that this change doesn't break others printers support?

@bleriotx
Copy link
Author

Sorry - I am new to all this and do not know the tools or the rules. This is why I was reluctant to get involved.
I have tested this on an M220, but do not own an M02 or M110 so cannot determine if it breaks them.

Probably better if somebody else reviews my findings in Issue #8 and determines if my changes are worthy.

@daig0rian
Copy link
Contributor

OK! I will review and test it on M110 !

@daig0rian
Copy link
Contributor

I have tested this pull request code and confirmed that it works on the M110 fine.
PXL_20230713_130203656
PXL_20230713_131153051
It is expected to work on M120 as well.

The main point of this pull request is to make the bitstream output by the CUPS driver closer to that of the official Windows driver released by Phomemo. This will solve issue #13 and also make this CUPS driver more compatible with the other Mxxx series.

@daig0rian
Copy link
Contributor

daig0rian commented Jul 13, 2023

The M110 and M220 can output images with more than 255 lines in a single BLOCK MARKER (i.e. GS v 0 command) without any problem. As far as I can tell, the M110 can output a 2398 line (=30cm) image in single BLOCK MARKER, and alsog the M110 and M220 Windows drivers only have single BLOCK MARKER, even for long label output.

@vivier
Copy link
Owner

vivier commented Jul 14, 2023

Please merge the 3 commits in 1.
(you can use "git rebase -i HEAD~3" and then replace the 2 last "pick" by "fixup")

@vivier
Copy link
Owner

vivier commented Jun 3, 2024

Closing the pull request as I don't know if it is relevant anymore.

@vivier vivier closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants