-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: feat (ui): insert filter by workspace in vitest ui #7157
base: main
Are you sure you want to change the base?
WIP: feat (ui): insert filter by workspace in vitest ui #7157
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -0,0 +1,54 @@ | |||
<script lang="ts"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a heads up, but we don't use object syntax, only script setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfectly, thanks for letting me know @sheremet-va 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need this PR #7146 or maybe we will need to add a new rpc call, right now running all the tests since we sent the files (missing project).
We should also remove project from local storage, we don't have the projects in the configuration and so we will need to reset it, maybe we should expose the projects in the configuration, otherwise we will have some race condition on initial load.
For example, using this PR modified on my local and re-running the forks
project in test/core
:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you merge main once #7213 merged and resolve conflicts? Once my PR merged, we'll have the projects available in the tree or whatever we want to move it |
Of course, I'll do that soon. Thank you @userquin |
b895c02
to
ac4e505
Compare
Description
This PR is still under development and refers to issue #7089
To Do List:
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.