Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/to equal undefined comparison #7134

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

STAR-173
Copy link

Fixes #7083

Description

This PR fixes the toEqual matcher to consistently ignore undefined properties when comparing objects. Previously, undefined properties were inconsistently highlighted in error messages, leading to confusion. The fix ensures predictable behavior and clearer error messages. Unit tests have been added to validate the changes.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@STAR-173
Copy link
Author

Hey @hi-ogawa ,
There are some test which are failing now which never failed before. Also, they are failing on the main branch.
Do you have any idea on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toEqual reports undefined when other keys do not match
1 participant