Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typecheck): fix typecheck collect on Vite 6 #6972

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Nov 27, 2024

Description

Fixing typecheck collect once more since wrapper changed from __vite_ssr_identity__ to (0, ...).

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 35516ac
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6746c91e1b56a3000807a201
😎 Deploy Preview https://deploy-preview-6972--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa
Copy link
Contributor Author

hi-ogawa commented Nov 27, 2024

I feel browser-multiple.test.ts is more flaky on Vite 6 https://github.com/vitest-dev/vitest/actions/runs/12045231693/job/33583503934?pr=6972#step:8:168

 ⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯
   FAIL  test/browser-multiple.test.ts > automatically assigns the port
  AssertionError: expected [ 'http://localhost:63315/', 'http://localhost:63317/' ] to include 'http://localhost:63316/'
   ❯ test/browser-multiple.test.ts:34:16
       32|   expect(stderr).not.toContain('is in use, trying another one...')
       33|   expect(urls).toContain('http://localhost:63315/')
       34|   expect(urls).toContain('http://localhost:63316/')
         |                ^
       35| })
       36| 
  ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯

Well, just realized http://localhost:63317 is very weird. Probably some browser port conflict with other tests? This should be addressed separately.

@hi-ogawa hi-ogawa marked this pull request as ready for review November 27, 2024 07:24
@sheremet-va sheremet-va merged commit 7b35d13 into vitest-dev:main Nov 27, 2024
17 checks passed
@hi-ogawa hi-ogawa deleted the fix-typecheck-vite-6 branch November 27, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants