-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: test Vite PR 18329 #6696
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hi-ogawa could you try if commenting out this part fixes the coverage? The new helper method added by Vite is on first line so I wonder if that's breaking here.
vitest/packages/vite-node/src/source-map.ts
Lines 64 to 68 in c4076e6
// If the first line is not present on source maps, add simple 1:1 mapping ([0,0,0,0], [1,0,0,0]) | |
// so that debuggers can be set to break on first line | |
if (map.mappings.startsWith(';')) { | |
map.mappings = `AAAA,CAAA${map.mappings}` | |
} |
@AriPerkkio Good find! Commenting out that mapping fixed the issue. There is a diff in I guess we need to find a different way to make inspect-brk work. |
For example, currently the first line but it's removed after removing first line mapping: |
I think for now it would be enough to set this breakpoint when we detect that |
Closing in favor of #6732 |
Description
Sourcemap viz of
fixtures/src/Vue/Counter/Counter.vue
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.