Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): restore splitpanes sizes #6679

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

userquin
Copy link
Member

@userquin userquin commented Oct 10, 2024

Description

Cannot test browser ui on my local Windows laptop, we need to check the side effect opening UI (test/core) and then the Browser UI (test/browser running any test:browser:* script)

resolves #6678

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 75ecb07
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6707c06e3228d70007f05546
😎 Deploy Preview https://deploy-preview-6679--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

{ size: mainSizes.value[0] },
{ size: mainSizes.value[1] },
])
if (browserState) {
Copy link
Member

@sheremet-va sheremet-va Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did it suddenly stop recording the main resize? recordMainResize affects how the browser displays panels

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We drop the middle panel in the default ui

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we don't drop it in the browser

Copy link
Member Author

@userquin userquin Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is in the ui not in the browser ui

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you saying it is ok to break the browser UI?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I need to test the changes in the browser ui, this change just fix the ui.

This shouldn't break the browser ui, the logic is the same, we only initilize the ui panels properly.

The problem is about using the same storage key for both, the ui and the browser ui.

@sheremet-va
Copy link
Member

Cannot test browser ui on my local Windows laptop, we need to check the side effect opening UI (test/core) and then the Browser UI (test/browser running any test:browser:* script)

Try deleting the node_modules folder and reinstalling dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI splitpanes sizes are no longer persisted to local storage
2 participants