-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): restore splitpanes sizes #6679
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
{ size: mainSizes.value[0] }, | ||
{ size: mainSizes.value[1] }, | ||
]) | ||
if (browserState) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did it suddenly stop recording the main resize? recordMainResize
affects how the browser displays panels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We drop the middle panel in the default ui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we don't drop it in the browser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is in the ui not in the browser ui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you saying it is ok to break the browser UI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I need to test the changes in the browser ui, this change just fix the ui.
This shouldn't break the browser ui, the logic is the same, we only initilize the ui panels properly.
The problem is about using the same storage key for both, the ui and the browser ui.
Try deleting the |
Description
Cannot test browser ui on my local Windows laptop, we need to check the side effect opening UI (test/core) and then the Browser UI (test/browser running any
test:browser:*
script)resolves #6678
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.