fix(expect)!: loosen toMatchObject
and objectContaining
for Proxy.get
#6675
+125
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm not sure if this behavior is the best, but I'm creating a PR to test a few things.
Technically this is a breaking change since people might be using negating
expect(someProxy).not.toMatchObject({ ... })
to assert proxy keys not being there.pros
Proxy.get
toMatchObject/objectContaining
already allows testing non-enumerable properties (e.g.Error.cause
)cons
Proxy.get
won't give better diff since non-enumerabletodo
toEqual
,toMatchObject
, etc... also diff formatPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.