Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI splitpanes sizes are no longer persisted to local storage #6678

Open
6 tasks done
posva opened this issue Oct 10, 2024 · 2 comments · May be fixed by #6679
Open
6 tasks done

UI splitpanes sizes are no longer persisted to local storage #6678

posva opened this issue Oct 10, 2024 · 2 comments · May be fixed by #6679
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)

Comments

@posva
Copy link
Contributor

posva commented Oct 10, 2024 •
edited
Loading

Describe the bug

It seems that there was a regression of #5166

  • vitest --ui
  • Resize splitpanes on the left
  • reload page
  • the left pane resets to the default size

I think that the initOnMounted option no longer takes effect since they were moved outside of a component. Maybe they should be exposed as functions instead of variables const useDetailsSizes = () => useLocalStorage(...)

Reproduction

https://stackblitz.com/edit/vitest-dev-vitest-enxjhj?file=README.md&initialPath=__vitest__/

(default repro, might have outdated deps but I tested locally too)

System Info

na

Used Package Manager

pnpm

Validations
@userquin userquin added p3-minor-bug An edge case that only affects very specific usage (priority) and removed pending triage labels Oct 10, 2024
@userquin
Copy link
Member

userquin commented Oct 10, 2024 •
edited
Loading

I guess we need to split logic for ui and browser ui: right now using mainSizes on UI when we should use detailSizes (in the new UI there is no details, the middle panel has been removed)

@userquin
Copy link
Member

userquin commented Oct 10, 2024 •
edited
Loading

Check the video, it is working again: https://streamable.com/8tzfxh

EDIT: we'll have some side effect when switching between UI and Browser UI: mainSizes and detailSizes for Browser UI and we should add a new sizes for UI /cc @sheremet-va

imagen

@userquin userquin linked a pull request Oct 10, 2024 that will close this issue
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): restore splitpanes sizes vitest-dev/vitest
2 participants
@posva @userquin