fix(bench): avoid bench being recognized consistent-test-it rule (#481)

vitest-dev · Jul 16, 2024 · 32c02f2 · 32c02f2
1 parent 6f186a1
commit 32c02f2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/rules/consistent-test-it.ts b/src/rules/consistent-test-it.ts
@@ -117,6 +117,8 @@ export default createEslintRule<
         }
       },
       CallExpression(node: TSESTree.CallExpression) {
+        if (node.callee.type === AST_NODE_TYPES.Identifier && node.callee.name === 'bench')
+          return
         const vitestFnCall = parseVitestFnCall(node, context)
 
         if (!vitestFnCall) return

diff --git a/tests/consistent-test-it.test.ts b/tests/consistent-test-it.test.ts
@@ -22,7 +22,13 @@ ruleTester.run(RULE_NAME, rule, {
   });
   function myTest() { if ('bar') {} }`,
       options: [{ fn: TestCaseName.it }]
-    }
+    },
+    {
+      code: `bench("foo", function () {
+        fibonacci(10);
+     })`,
+      options: [{ fn: TestCaseName.it }]
+    },
   ],
   invalid: [
     {