fix(css): also remove empty style chunk when cssCodeSplit: false (fixes #16582)
#16585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
susnux
changed the title
cssCodeSplit: falsecssCodeSplit: false (fixes #16582)
susnux
force-pushed
the
fix/also-remove-empty-chunks-without-csscodesplit
branch
3 times, most recently
from
456e3cd
to
d480b65
Compare
susnux
changed the title
cssCodeSplit: false (fixes #16582)cssCodeSplit: false (fixes #16582)
Resolves vitejs#16582 When setting `cssCodeSplit: false` the styles are still split into one style file. But currently the imported CSS results in empty chunks, as in the current implementation empty chunks are only removed when `cssCodeSplit` was set to `true`. So this also adds empty style chunks to `pureCSSChunks` even with `cssCodeSplit: false`. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/also-remove-empty-chunks-without-csscodesplit
branch
from
d480b65
to
e0a0cf3
Compare
5 tasks
|
@sapphi-red yes it does! And it provides tests 🚀 |
|
Closing in favor of #16078 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cssCodeSplit = falseand css imports #16582When setting
cssCodeSplit: falsethe styles are still split into one style file, but currently the imported CSS results in empty chunks as in the current implementation empty chunks are only removed whencssCodeSplitwas set totrue.So this also adds empty style chunks to
pureCSSChunkseven withcssCodeSplit: false.