fix(legacy): improve deterministic build of the polyfill bundle by sorting the polyfills discovered by babel #16505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
7 tasks
shankerwangmiao
force-pushed
the
fix-legacy-polyfill-deterministic
branch
2 times, most recently
from
b03e8c5
to
2b44e8a
Compare
shankerwangmiao
force-pushed
the
fix-legacy-polyfill-deterministic
branch
from
2b44e8a
to
bb79c9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The polyfill bundle generated by the legacy plugin is non deterministic, because the order of calling
renderChunk()affects the input of the finally generated polyfill bundle.This PR solves this issue by sorting the polyfills in need discovered by babel. The polyfills added directly from the plugin configuration is kept ordered the first, same as before.
Previously, #13672 (comment) mentioned this issue.