Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(create-vite): improve project name inference from path #16490

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(create-vite): improve project name inference from path #16490

wants to merge 5 commits into from

Conversation

brownieboy
Copy link

Description

Fixes #16470

@stackblitz StackBlitz
Copy link

stackblitz bot commented Apr 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@brownieboy brownieboy changed the title Feat/16470 project name from path feat: project name from path Apr 22, 2024
@brownieboy
Copy link
Author

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Sorry, I'm not sure what the process is at this point. Am I supposed to review the code in StackBlitz myself?

bluwy
bluwy reviewed Apr 29, 2024
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm not sure what the process is at this point. Am I supposed to review the code in StackBlitz myself?

The link is only for us to review, you can ignore it.

This seem fine to me with only one nit. I also think it's more of a fix than a feature. We weren't guessing the name properly with paths.

docs/guide/index.md
Copy link
Member

@bluwy bluwy Apr 29, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for elaborating the feature, but I think we should keep it like before since the project name infer is QoL feature and shouldn't take much space in the docs.

@bluwy bluwy added p2-nice-to-have Not breaking anything but nice to have (priority) feat: create-vite create-vite package labels Apr 29, 2024
@bluwy bluwy changed the title feat: project name from path fix(create-vite): improve project name inference from path Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feat: create-vite create-vite package p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set project name automatically when target includes a path
2 participants
@brownieboy @bluwy