fix(hmr): watch files in workspace root #16473
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
feat: hmr
p4-important
|
|
|
Hmm, the test fails 🤔 |
sapphi-red
commented
Apr 19, 2024
Comment on lines
460
to
461
| ...config.configFileDependencies, | ||
| ...getEnvFilesForMode(config.mode, config.envDir), |
There was a problem hiding this comment.
I found that pnpm test-serve /css/ passes if I comment out these lines. Maybe there's a bug here 🤔 But even with that running the whole test (pnpm test-serve) takes a long time. I guess it's because we have many files under the repository.
There was a problem hiding this comment.
I'm worried about the performance impact of watching the whole fs root. What I'm thinking now is that we may need to be more fine-grained. Maybe we could automatically watch parent folders in a shallow way (not deep watch) of every imported file for example.
For now, I think we should revert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #16399
refs #15712
We need to make these values consistent. Otherwise, the cache could be different from the actual file system.
vite/packages/vite/src/node/server/index.ts
Line 479 in 6a127d6
vite/packages/vite/src/node/fsUtils.ts
Line 134 in 6a127d6
Alternative fix for this is to revert #15712. I'm not sure if which is safer. Maybe reverting it in a patch and reapplying it in the next minor?