fix: fix ssr.optimizeDeps.include with dep1 > dep2 syntax
#16408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hi-ogawa
commented
Apr 12, 2024
| @@ -26,6 +26,7 @@ | |||
| "@vitejs/test-non-optimized-with-nested-external": "workspace:*", | |||
| "@vitejs/test-optimized-with-nested-external": "file:./optimized-with-nested-external", | |||
| "@vitejs/test-optimized-cjs-with-nested-external": "file:./optimized-with-nested-external", | |||
| "@vitejs/test-nested-exclude": "file:./nested-exclude", | |||
There was a problem hiding this comment.
For the test case, I copied the same fixture used in playground/optimize-deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ssr.optimizeDeps.includewithdep1 > dep2syntax not working #16405I'm not totally sure if this is a right fix, but it seems to work when testing a patch locally. Let me check with CI.
Considering ssr deps optimization is only done by resolving explicitly specified
include, I'm not sure what's the purpose of__vite_skip_optimization. Could someone explain what's the idea behind this?