Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: build assets with the entry name when it is an entry point (#11578) #14944

Closed
wants to merge 1 commit into from

Conversation

patak-dev
Copy link
Member

Fixes #14943

This reverts commit fd9a2cc.

Description

Given that we are close to the release and the PR will break several integrations, I think it is better to revert #11578 at this point and work with downstream projects with more time if we intend to change this.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev patak-dev added the p3-significant High priority enhancement (priority) label Nov 10, 2023
@patak-dev patak-dev added this to the 5.0 milestone Nov 10, 2023
@sapphi-red
Copy link
Member

I guess it's better to avoid changing the output filename in minors, and also #9877 is quite difficult to workaround. So I think it's better to fix it if the release only delays several days. (#14945)

@patak-dev
Copy link
Member Author

Closing in favor of #14945

@patak-dev patak-dev closed this Nov 11, 2023
@sapphi-red sapphi-red deleted the revert-11578 branch November 11, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-significant High priority enhancement (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect manifest.json path for css entrypoint files (v5.0.0-beta.17)
2 participants