Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update working solutions to watch a package inside node_modules/ #13353

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented May 27, 2023

Document working solutions to watch a package inside node_modules/

The current server.watch docs aren't accurate and the solution proposed just doesn't work, see #8619. There is a different workaround in the issue using a custom Vite plugin if you're using the Vite dev server which this PR points to instead.

There isn't a known workaround for Vite build though (build.watch)

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented May 27, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@MadLittleMods MadLittleMods marked this pull request as draft May 27, 2023 01:11
@MadLittleMods MadLittleMods changed the title Document working solutions to watch a package inside node_modules/ docs: Document working solutions to watch a package inside node_modules/ May 27, 2023
@MadLittleMods MadLittleMods force-pushed the madlittlemods/update-watch-option-docs branch from b65ec7c to 79599d4 Compare May 27, 2023 01:13
@MadLittleMods MadLittleMods changed the title docs: Document working solutions to watch a package inside node_modules/ docs: update working solutions to watch a package inside node_modules/ May 27, 2023
@MadLittleMods MadLittleMods marked this pull request as ready for review May 27, 2023 01:15
The current `server.watch` docs aren't accurate and the solution
proposed just doesn't work. See vitejs#8619

There is a different workaround in the issue using a custom Vite plugin
if you're using the Vite dev server, vitejs#8619 (comment)
@MadLittleMods MadLittleMods force-pushed the madlittlemods/update-watch-option-docs branch from 79599d4 to 57193ec Compare May 27, 2023 01:17
@bluwy bluwy mentioned this pull request Sep 25, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant