feat: legacy build of web workers #12320
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10383
Description
Enable web workers to be built correctly for legacy browsers.
The current situation is that the workers are built by themselves via the internal node plugin
worker.js
, ignoring any legacy output that is desired.For fixing this issue in the ideal way, the changes should be both for
plugin-legacy
and for the internal node pluginworker.js
.Here is my roadmap(including explanations and more), I will be glad to hear your opinion about it:
workerPlugins
field from the plugin-legacy, that is responsible for transforming the rendered chunk to an actual one that is legacy-safe. Note: The user needs to manually put this result field in the Vite configurationworker.plugins
. Sadly, this worker's rollup plugin cannot be registered now automatically, because Vite forbid/ignore when one plugin change the configuration for loading a different plugin in theconfig
step of Vite plugins.Promise
and therefore needs to load legacy polyfills.window
ordocument
, and it's not available in web workers context, we need to have another configuration "additionalPolyfillsDocumentSensitive", which all of them will be build and injected to the big polyfill file, but with a big "if" statment that apply them if we're in a document context(i.e. not in a web worker).worker.plugins
will know more details about the specific output. This will allow the plugin-legacy to know if we're building the legacy or the modern chunk, and more info.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).