Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect manifest.json path for css entrypoint files (v5.0.0-beta.17) #14943

Closed
7 tasks done
lubomirblazekcz opened this issue Nov 10, 2023 · 1 comment · Fixed by #14945
Closed
7 tasks done

Incorrect manifest.json path for css entrypoint files (v5.0.0-beta.17) #14943

lubomirblazekcz opened this issue Nov 10, 2023 · 1 comment · Fixed by #14945

Comments

@lubomirblazekcz
Copy link
Contributor

lubomirblazekcz commented Nov 10, 2023

Describe the bug

As mentioned in #11578 (comment), vite v5 includes bad path to manifest.json in case css file is entrypoint.

Reproduction

bellow

Steps to reproduce

Here is a reproduction, run npm run build

v4.5.0
https://stackblitz.com/edit/vitejs-vite-xgwzla?file=vite.config.js,dist%2Fmanifest.json

src/style.css is included correctly in manifest.json

v5.0.0-beta.17
https://stackblitz.com/edit/vitejs-vite-ma53cs?file=vite.config.js,dist%2Fmanifest.json

style.css is included incorrectly in manifest.json, path should be same as in the case with src/main.js. This was an issue that was previously fixed in v3 or v4

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.18.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.4.2 - /usr/local/bin/npm
    pnpm: 8.9.2 - /usr/local/bin/pnpm
  npmPackages:
    vite: ^5.0.0-beta.17 => 5.0.0-beta.17

Used Package Manager

npm

Logs

No response

Validations

@lubomirblazekcz
Copy link
Contributor Author

This would definetly break a lot of backend integrations like Laravel that depends on these full entrypoint paths, such as https://laravel.com/docs/10.x/vite#configuring-vite or https://vituum.dev/config/main-options.html#input

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant