Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ts expression should work well in the pug template #123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jevon617
Copy link

@Jevon617 Jevon617 commented Mar 6, 2023

Description

Fix #18

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p2-nice-to-have 🍰 Not breaking anything but nice to have (priority) enhancement New feature or request labels Mar 7, 2023
@sid-6581
Copy link

Any chance we can get this merged? This bug is affecting me quite a bit.

@or2e
Copy link

or2e commented Jun 27, 2023

bump

@juzser
Copy link

juzser commented Jul 19, 2023

+1

@vladfaust
Copy link

Almost always it is possible to extract Typescript to the <script lang="ts"> tag and only use Javascript in <template lang="pug">. Yet the life would be much easier if this PR got merged. Thank you, @Jevon617.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p2-nice-to-have 🍰 Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript types in pug templates get not removed
6 participants