fix: align jsx runtime for optimized dependencies #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patak-dev
reviewed
Nov 16, 2023
src/index.ts
Outdated
| @@ -83,6 +83,7 @@ const react = (_options?: Options): PluginOption[] => { | |||
| esbuild: false, | |||
| optimizeDeps: { | |||
| include: [`${options.jsxImportSource}/jsx-dev-runtime`], | |||
| esbuildOptions: { jsx: "transform" }, | |||
There was a problem hiding this comment.
Probably I'm missing something, but why is it here "transform" and in the other plugin "automatic"? vitejs/vite-plugin-react@96b66ed#diff-d1f942b9a74f586a80bca3733150b7c692a6460e8350bc19cbbad1d53f95b356R134
There was a problem hiding this comment.
I was just try things locally and didn't revert 🙈
ArnaudBarre
force-pushed
the
optimized-deps-jsx-automatic
branch
from
29b2ecf to
91dc70c
Compare
patak-dev
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.