Support django model type annotations #974
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 馃憢
First, thanks a lot for this lib! It really helped us deliver better quality software.
We are developing a (close to) fully typed application using Django. In lots of models we explicitly specify the type of the fields when the basic type is not precise enough, for example:
The issue arises when we define the associated Pydantic models, we have to redefine the types for those fields:
This PR makes
ModelSchema
aware of the type annotations and allow the previous schema to be defined as... so we are not repeating the type and avoid runtime errors when there is a Django model/Pydantic model mismatch.
This is a draft that would require more work/testing, let me know if you think this is an idea worth pursuing.
Cheers!