feat(django_getter): use function cache to increase performance #1150
+61
−51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
After using ninja a lot, I noticed some performance benefit could be made in DjangoGetter, by caching the actual function being called and using a lookup, instead of doing up to 4 checks each time.
This MR implements this simple cache.
I didn't specifically add tests for this, as schema is tested very well throughout the rest of the tests. Let me know if you'd like to see this differently.
Let me know what you think!
Some data: