Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent reset the node color to the group color from storePositions function #1691

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

veredwpsemantix
Copy link

This pull request fixes the reset of node color when we call to storePositions function.

Example:
before storePositions:
Screenshot1

after storePositions:
Screenshot2

@Thomaash Thomaash added the can't reproduce Something has been reported but seems to work fine label Feb 25, 2022
@Thomaash
Copy link
Member

Hi @veredwpsemantix,

could you provide an MWE of the issue please? From what you posted this seems like a pretty serious issue in vis-data and should therefore be fixed there. What you provided is more of a hack around it (assuming I understand the problem correctly, which is difficult to gauge without an MWE).

Thanks and sorry for the atrocious response time

PS: There are JSFiddle and CodePen buttons on https://visjs.github.io/vis-network/examples/ to make MWE creation easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can't reproduce Something has been reported but seems to work fine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants