Fix QString::SplitBehavior deprecation, replace with Qt:: #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following links are available: build (ubuntu-18.04, full)
build (macOS-latest, full) build (windows-latest, full) |
daleglass
added
needs CR (code review)
needs testing (QA)
ctrlaltdavid
approved these changes
Aug 7, 2021
ctrlaltdavid
added
CR Approved
|
Looks like this PR didn't build on Android...likely because wrong QT version? How long has Android build been broken? |
|
Android builds have been broken for quite some time now. I would guess around two months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bunch of this:
‘QStringList QString::split(const QRegExp&, QString::SplitBehavior) const’ is deprecated: Use Qt::SplitBehavior variant instead [-Wdeprecated-declarations]