Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: build-vm command to os subcommand #74

Closed
wants to merge 1 commit into from

Conversation

xiro-codes
Copy link

Implements build-vm command into nh

@viperML
Copy link
Owner

viperML commented Mar 8, 2024

Couldn't this be retrofitted into OsRebuildArgs::rebuild instead?

@xiro-codes
Copy link
Author

xiro-codes commented Mar 8, 2024

Ill look into it, also love your blog it really helped me get into nix early on.

@viperML
Copy link
Owner

viperML commented Mar 10, 2024

So what do you want to do with this command? It is named build-vm, but it actually runs the vm. Also it shouldn't install it into the system profile, and probably neither ask for confirmation or diff.

Edit: in hindsight perhaps it would be better to split it off OsRebuildArgs::rebuild

@xiro-codes
Copy link
Author

xiro-codes commented Mar 10, 2024

I needed to test my config that was broken. so i added it didn't think much farther than that. but the unneeded sudo request is a problem
ps. it was still broken but its fixed now

@xiro-codes
Copy link
Author

Question how do I keep the tmp dir everything is created in so I can ask if they want to run vs just build the vm

@viperML viperML closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants