Fix a few PHP 8 related issues #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiosalvatore
approved these changes
Feb 15, 2024
MelechMizrachi
force-pushed
the
fix-php-8-issues
branch
from
dc82515
to
cedc46c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SelectProcessor.php expected the return value of
Evaluatorto be an array for the case where the expression is aSubqueryExpression, butEvaluatoralready ensures the value returned is the value of the column requested. Also removing assertion as it does nothing in a production environment and might be mistaken as a stopper to run the code.BinaryOperatorEvaluator.php would blindly try to divide any right/left value by the other without checking for 0 first.